Re: [PATCH] infiniband: remove WARN that is not kernel bug

From	Dmitry Vyukov <dvyukov@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] infiniband: remove WARN that is not kernel bug
Date	2016-11-21 11:30 +0100
Message-ID	<sFU1k-8p7-31@gated-at.bofh.it> (permalink)
References	<sEPwK-6s7-35@gated-at.bofh.it> <sF3zH-7an-1@gated-at.bofh.it> <sFj1L-ga-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Nov 19, 2016 at 7:57 PM, Jason Gunthorpe
<jgunthorpe@obsidianresearch.com> wrote:
> On Fri, Nov 18, 2016 at 09:22:42PM -0500, Valdis.Kletnieks@vt.edu wrote:
>> On Fri, 18 Nov 2016 12:24:37 +0100, Dmitry Vyukov said:
>> > WARNINGs mean kernel bugs.
>> > The one in ucma_write() points to user programming error
>> > or a malicious attempt. This is not a kernel bug, remove it.
>>
>> > -   if (WARN_ON_ONCE(!ib_safe_file_access(filp)))
>> > +   if (!ib_safe_file_access(filp))
>> >             return -EACCES;
>>
>> In that case, wouldn't this be better?
>>
>>       if (!ib_safe_file_access(filp)) {
>>               printk_once("Process %d (%s) tried to do something hinky", pid, comm);
>>               return _EACCESS;
>>       }
>>
>> so the sysadmin becomes aware of the malicious attempt?
>
> Yes please

Mailed v2

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] infiniband: remove WARN that is not kernel bug Dmitry Vyukov <dvyukov@google.com> - 2016-11-18 12:30 +0100
  Re: [PATCH] infiniband: remove WARN that is not kernel bug Valdis.Kletnieks@vt.edu - 2016-11-19 03:30 +0100
    Re: [PATCH] infiniband: remove WARN that is not kernel bug Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-19 20:00 +0100
      Re: [PATCH] infiniband: remove WARN that is not kernel bug Dmitry Vyukov <dvyukov@google.com> - 2016-11-21 11:30 +0100

csiph-web