Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1521902

Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in flight

Show all headers | View raw

On Mon, Nov 14, 2016 at 04:59:48PM +0000, James Simmons wrote:
> 
> > On Thu, Nov 10, 2016 at 10:51:13AM -0500, James Simmons wrote:
> > > From: Gregoire Pichon <gregoire.pichon@bull.net>
> > > 
> > > This patch is the main client part of a new feature that supports
> > > multiple modify metadata RPCs in parallel. Its goal is to improve
> > > metadata operations performance of a single client, while maintening
> > > the consistency of MDT reply reconstruction and MDT recovery
> > > mechanisms.
> > > 
> > > It allows to manage the number of modify RPCs in flight within
> > > the client obd structure and to assign a virtual index (the tag) to
> > > each modify RPC to help server side cleaning of reply data.
> > > 
> > > The mdc component uses this feature to send multiple modify RPCs
> > > in parallel.
> > 
> > Is this a new feature?  Why should we take this now and not just wait
> > until the code is out of staging?
> 
> Yes on the server side. So the problem on our meta data servers couldn't
> handle writing mulitiple bits of data to the back end disk at ths same
> time.
> 
> One client side the issue was the metadata operations were being 
> serialized by a mutex in the MDC layer. That is what this patch fixed.
> So for the client it would be a performance improvement patch. 

So, it's a "performance" patch, which isn't functionality, so why should
we merge this to staging now?  Why aren't people working on the known
coding issues to get this out of staging instead of working on
performance stuff?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in  flight Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-14 16:20 +0100
  Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs  in flight James Simmons <jsimmons@infradead.org> - 2016-11-14 18:00 +0100
    Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in  flight Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-14 18:30 +0100
      Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs  in flight James Simmons <jsimmons@infradead.org> - 2016-11-14 18:30 +0100
        Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in  flight Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-15 11:10 +0100

csiph-web