Re: [PATCH v2 1/2] arm64: dts: Add level for cpu dt node for exynos7

From	Alim Akhtar <alim.akhtar@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] arm64: dts: Add level for cpu dt node for exynos7
Date	2016-11-14 07:10 +0100
Message-ID	<sDiCS-37w-11@gated-at.bofh.it> (permalink)
References	<sCDzH-GU-3@gated-at.bofh.it> <sCHtD-3dB-15@gated-at.bofh.it> <sCJ2p-4hQ-3@gated-at.bofh.it> <sDiCS-37w-13@gated-at.bofh.it> <sCM0i-6hX-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof,

On 11/13/2016 12:43 AM, Krzysztof Kozlowski wrote:
> On Sat, Nov 12, 2016 at 6:00 PM, Alim Akhtar <alim.akhtar@gmail.com> wrote:
>> Hi Javier,
>>
>> On Sat, Nov 12, 2016 at 7:54 PM, Javier Martinez Canillas
>> <javier@osg.samsung.com> wrote:
>>> Hello Alim,
>>>
>>> On 11/12/2016 07:17 AM, Alim Akhtar wrote:
>>>> This patch adds level for cpu dt node, so that these levels can be used
>>>
>>> Do you mean s/level/label here? I'm asking because you are using level
>>> consistently in the subject line and commit message but I'm not sure
>>> what it means in this context.
>>>
>>
>> Ah!! my bad. Its __label__. If required, will respin.
>> Thanks for review.
>
> I think there is no need of respin because this should be squashed
> with previous patch. This is quite small and there are no functional
> changes here (labels are transparent, except of course conflict
> cases). Without the 2/2,  this patch does not have much sense yet.
>
The reason why I kept the _label_ changes are separate patch is to keep 
git bisect happy. If you think there won't be a case for that, then lets 
merge the two in single patch.
Let me know if you want me to respin or you will take care.

> Best regards,
> Krzysztof
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] arm64: dts: Add level for cpu dt node for exynos7 Alim Akhtar <alim.akhtar@samsung.com> - 2016-11-12 11:20 +0100
  Re: [PATCH v2 1/2] arm64: dts: Add level for cpu dt node for exynos7 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-12 15:30 +0100
    Re: [PATCH v2 1/2] arm64: dts: Add level for cpu dt node for exynos7 Alim Akhtar <alim.akhtar@gmail.com> - 2016-11-12 17:10 +0100
      Re: [PATCH v2 1/2] arm64: dts: Add level for cpu dt node for exynos7 Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-12 20:20 +0100
        Re: [PATCH v2 1/2] arm64: dts: Add level for cpu dt node for exynos7 Alim Akhtar <alim.akhtar@samsung.com> - 2016-11-14 07:10 +0100

csiph-web