Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522486

Re: [PATCH v2 02/10] dt-bindings: add documentation for rk1108 cru

Show all headers | View raw

Hi Andy,

Am Montag, 14. November 2016, 20:03:01 CET schrieb Andy Yan:
> From: Shawn Lin <shawn.lin@rock-chips.com>
> 
> This adds the dt-binding documentation for the clock and reset unit
> found on Rockchip rk1108 SoCs.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
> 
> Changes in v2: None
> 
>  .../bindings/clock/rockchip,rk1108-cru.txt         | 60
> ++++++++++++++++++++++ 1 file changed, 60 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/clock/rockchip,rk1108-cru.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk1108-cru.txt
> b/Documentation/devicetree/bindings/clock/rockchip,rk1108-cru.txt new file
> mode 100644
> index 0000000..4d2356b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk1108-cru.txt
> @@ -0,0 +1,60 @@
> +* Rockchip RK1108 Clock and Reset Unit
> +
> +The RK1108 clock controller generates and supplies clock to various
> +controllers within the SoC and also implements a reset controller for SoC
> +peripherals.
> +
> +Required Properties:
> +
> +- compatible: should be "rockchip,rk1108-cru"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- #clock-cells: should be 1.
> +- #reset-cells: should be 1.
> +
> +Optional Properties:
> +
> +- rockchip,grf: phandle to the syscon managing the "general register files"
> +  If missing pll rates are not changeable, due to the missing pll lock
> status. +
> +Each clock is assigned an identifier and client nodes can use this
> identifier +to specify the clock which they consume. All available clocks
> are defined as +preprocessor macros in the dt-bindings/clock/rk1108-cru.h
> headers and can be +used in device tree sources. Similar macros exist for
> the reset sources in +these files.
> +
> +External clocks:
> +
> +There are several clocks that are generated outside the SoC. It is expected
> +that they are defined using standard clock bindings with following
> +clock-output-names:
> + - "xin24m" - crystal input - required,
> + - "cif_clkout" - output clock for the cif - optional
> + - "mipi_csi_clkout" - output clock for the mipi csi - optional
> + - "pclkin_vip" - external VIP clock - optional
> + - "ext_i2s" - external I2S clock - optional
> + - "ext_gmac" - external GMAC clock - optional
> + - "mac_ref_clkout" - output clock of the pll in the mac phy

we really only want to list the actual input clocks here, not outputs.

Also, the list of actual input clocks seems incomplete (hdmiphy, usbphy) and 
some clocks listed here do not match the clock controller 2 patches later 
(pclkin_vip, ext_gmac [rk1108 only has 10/100], ext_i2s, ...)


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/10] Add basic support for Rockchip RK1108 SOC Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:00 +0100
  [PATCH v2 03/10] clk: rockchip: add dt-binding header for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:10 +0100
    Re: [PATCH v2 03/10] clk: rockchip: add dt-binding header for rk1108 Heiko Stuebner <heiko@sntech.de> - 2016-11-15 10:50 +0100
      Re: [PATCH v2 03/10] clk: rockchip: add dt-binding header for rk1108 Shawn Lin <shawn.lin@rock-chips.com> - 2016-11-16 01:50 +0100
  [PATCH v2 02/10] dt-bindings: add documentation for rk1108 cru Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:10 +0100
    Re: [PATCH v2 02/10] dt-bindings: add documentation for rk1108 cru Heiko Stuebner <heiko@sntech.de> - 2016-11-15 10:40 +0100
      Re: [PATCH v2 02/10] dt-bindings: add documentation for rk1108 cru Shawn Lin <shawn.lin@rock-chips.com> - 2016-11-16 01:50 +0100
  [PATCH v2 01/10] dt-bindings: rockchip-dw-mshc: add RK1108 dw-mshc description Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:10 +0100
    Re: [PATCH v2 01/10] dt-bindings: rockchip-dw-mshc: add RK1108 dw-mshc description Heiko Stuebner <heiko@sntech.de> - 2016-11-15 00:20 +0100
  [PATCH v2 04/10] clk: rockchip: add clock controller for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:10 +0100
    Re: [PATCH v2 04/10] clk: rockchip: add clock controller for rk1108 Heiko Stuebner <heiko@sntech.de> - 2016-11-15 11:40 +0100
  [PATCH v2 09/10] ARM: rockchip: enable support for RK1108 SoC Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:20 +0100
    Re: [PATCH v2 09/10] ARM: rockchip: enable support for RK1108 SoC Heiko Stuebner <heiko@sntech.de> - 2016-11-15 12:40 +0100
  [PATCH v2 07/10] ARM: add low level debug uart for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:20 +0100
    Re: [PATCH v2 07/10] ARM: add low level debug uart for rk1108 Heiko Stuebner <heiko@sntech.de> - 2016-11-15 12:40 +0100
  [PATCH v2 06/10] pinctrl: rockchip: add support for rk1108 Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:20 +0100
    Re: [PATCH v2 06/10] pinctrl: rockchip: add support for rk1108 Heiko Stuebner <heiko@sntech.de> - 2016-11-15 00:30 +0100
    Re: [PATCH v2 06/10] pinctrl: rockchip: add support for rk1108 Linus Walleij <linus.walleij@linaro.org> - 2016-11-15 10:40 +0100
  [PATCH v2 10/10] ARM: dts: rockchip: add rockchip RK1108 Evaluation board Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:20 +0100
    Re: [PATCH v2 10/10] ARM: dts: rockchip: add rockchip RK1108 Evaluation board Heiko Stuebner <heiko@sntech.de> - 2016-11-16 13:00 +0100
  [PATCH v2 08/10] ARM: dts: add basic support for Rockchip RK1108 SOC Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:20 +0100
    Re: [PATCH v2 08/10] ARM: dts: add basic support for Rockchip RK1108 SOC Heiko Stuebner <heiko@sntech.de> - 2016-11-15 12:50 +0100
      Re: [PATCH v2 08/10] ARM: dts: add basic support for Rockchip RK1108 SOC Heiko Stuebner <heiko@sntech.de> - 2016-11-16 13:00 +0100
  [PATCH v2 05/10] dt-bindings: add documentation for rk1108 pinctrl Andy Yan <andy.yan@rock-chips.com> - 2016-11-14 13:20 +0100
    Re: [PATCH v2 05/10] dt-bindings: add documentation for rk1108 pinctrl Heiko Stuebner <heiko@sntech.de> - 2016-11-15 00:20 +0100
    Re: [PATCH v2 05/10] dt-bindings: add documentation for rk1108 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2016-11-15 10:40 +0100

csiph-web