Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517662
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drivers: tca8418: Change the interrupt type |
| Date | 2016-11-09 01:10 +0100 |
| Message-ID | <sBoCJ-8eR-1@gated-at.bofh.it> (permalink) |
| References | <sATpf-4qY-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Nov 07, 2016 at 03:40:24PM +0100, Maxime Ripard wrote: > The TCA8418 interrupt has a level trigger, not a edge one. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Hmm, maybe we could rely on OF data for trigger type? > --- > drivers/input/keyboard/tca8418_keypad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c > index 9002298698fc..b88b3696a2e1 100644 > --- a/drivers/input/keyboard/tca8418_keypad.c > +++ b/drivers/input/keyboard/tca8418_keypad.c > @@ -360,7 +360,7 @@ static int tca8418_keypad_probe(struct i2c_client *client, > irq = gpio_to_irq(irq); > > error = devm_request_threaded_irq(dev, irq, NULL, tca8418_irq_handler, > - IRQF_TRIGGER_FALLING | > + IRQF_TRIGGER_LOW | > IRQF_SHARED | > IRQF_ONESHOT, > client->name, keypad_data); > -- > 2.10.1 > -- Dmitry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drivers: tca8418: Change the interrupt type Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-07 15:50 +0100
Re: [PATCH] drivers: tca8418: Change the interrupt type Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-09 01:10 +0100
Re: [PATCH] drivers: tca8418: Change the interrupt type Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-09 09:10 +0100
Re: [PATCH] drivers: tca8418: Change the interrupt type Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-10 05:10 +0100
Re: [PATCH] drivers: tca8418: Change the interrupt type Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-10 10:20 +0100
csiph-web