Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads
Date	2016-11-08 16:50 +0100
Message-ID	<sBgOS-2Jy-29@gated-at.bofh.it> (permalink)
References	(3 earlier) <sAL8l-7dK-5@gated-at.bofh.it> <sBbFw-84M-31@gated-at.bofh.it> <sBc8x-8ek-9@gated-at.bofh.it> <sBeDn-1rd-5@gated-at.bofh.it> <sBf6q-1Bm-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 8, 2016 at 2:35 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> There is two types of configuration in given platform, the IO voltage does
> not get change (fixed in given platform) and in some of cases, get change
> dynamically like SDIO3.0 where the voltage switches to 3.3V and 1.8V.
>
> Yes, it can be integrated with the regulator handle and then it can call the
> required configurations through notifier and regulator_get_voltage().
> But I think it is too much complex for the static configurations. This
> mandate also to populate the regulator handle and all power tree.
>
> The simple way for static configuration (case where voltage does not get
> change), just take the power tree IO voltage from DT and configure the IO
> pad control register.
>
> For dynamic case, there is some sequence need to be followed based on
> voltage direction change (towards lower or towards higher) for the voltage
> change and the IO pad voltage configuration and it is simple to do it from
> client driver.

The devicetree should describe the platform.

Adding this custom attribute does not describe the platform very
well since the dependency to the corresponding regulator is hidden.

The point of device tree is not as much to make things simple as
to describe the world properly.

So to me it is simple: use regulators and phandles.

It might require a bit of upfront coding but the result will look
much nicer.

Yours,
Linus Walleij

Thread

[PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-02 10:30 +0100
  Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Linus Walleij <linus.walleij@linaro.org> - 2016-11-04 23:30 +0100
    Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-07 07:00 +0100
      Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 11:20 +0100
        Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-08 11:50 +0100
          Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 14:30 +0100
            Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-08 15:00 +0100
              Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Thierry Reding <thierry.reding@gmail.com> - 2016-11-08 15:50 +0100
                Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-08 17:10 +0100
              Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 16:50 +0100
                Re: [PATCH 2/2] pinctrl: tegra: Add driver to configure voltage and  power of io pads Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-08 17:10 +0100

csiph-web