[PATCH 3/3] serial: crisv10: fix invalid user-pointer check

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] serial: crisv10: fix invalid user-pointer check
Date	2016-11-08 13:30 +0100
Message-ID	<sBdHk-SQ-11@gated-at.bofh.it> (permalink)
References	<sBdHj-SQ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Drop invalid user-pointer check from TIOCGSERIAL handler.

A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.

Cc: Mikael Starvik <starvik@axis.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: linux-cris-kernel@axis.com
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/tty/serial/crisv10.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
index 315c84979b18..d4cb6ff52e7a 100644
--- a/drivers/tty/serial/crisv10.c
+++ b/drivers/tty/serial/crisv10.c
@@ -3214,8 +3214,6 @@ get_serial_info(struct e100_serial * info,
 	 * should set them to something else than 0.
 	 */
 
-	if (!retinfo)
-		return -EFAULT;
 	memset(&tmp, 0, sizeof(tmp));
 	tmp.type = info->type;
 	tmp.line = info->line;
-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] serial: crisv10: fix invalid user-pointer check Johan Hovold <johan@kernel.org> - 2016-11-08 13:30 +0100
  Re: [PATCH 3/3] serial: crisv10: fix invalid user-pointer check Jesper Nilsson <jesper.nilsson@axis.com> - 2016-11-08 14:00 +0100

csiph-web