Re: [PATCH v2 1/3] firmware: qcom: scm: add a video command for state setting

From	Stanimir Varbanov <stanimir.varbanov@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] firmware: qcom: scm: add a video command for state setting
Date	2016-11-10 09:10 +0100
Message-ID	<sBSAN-2Uu-3@gated-at.bofh.it> (permalink)
References	<sAW3M-6lw-7@gated-at.bofh.it> <sAW3N-6lw-53@gated-at.bofh.it> <sBMOJ-7gR-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 11/10/2016 03:52 AM, Stephen Boyd wrote:
> On 11/07, Stanimir Varbanov wrote:
>> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
>> index d95c70227c05..7e364691a87c 100644
>> --- a/drivers/firmware/qcom_scm.c
>> +++ b/drivers/firmware/qcom_scm.c
>> @@ -320,6 +320,22 @@ bool qcom_scm_is_available(void)
>>  }
>>  EXPORT_SYMBOL(qcom_scm_is_available);
>>  
>> +int qcom_scm_video_set_state(u32 state, u32 spare)
>> +{
>> +	int ret;
>> +
>> +	ret = qcom_scm_clk_enable();
> 
> Do we need clk control for this? Usually it's only required for
> crypto engine things, and turning on video doesn't sound like it
> uses crypto. I don't think downstream android kernel does this.

Correct, the crypto clk is not needed.

-- 
regards,
Stan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Venus remoteproc driver Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-11-07 18:40 +0100
  [PATCH v2 3/3] remoteproc: qcom: add Venus video core firmware loader driver Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-11-07 18:40 +0100
  [PATCH v2 1/3] firmware: qcom: scm: add a video command for state setting Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-11-07 18:40 +0100
    Re: [PATCH v2 1/3] firmware: qcom: scm: add a video command for  state setting Stephen Boyd <sboyd@codeaurora.org> - 2016-11-10 03:00 +0100
      Re: [PATCH v2 1/3] firmware: qcom: scm: add a video command for state  setting Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-11-10 09:10 +0100

csiph-web