Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515591

Re: [PATCH] HID: intel-ish-hid: initialize ts_format.reserved

Show all headers | View raw

On Sat, 2016-11-05 at 16:15 +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> ts_format.reserved is not used anywhere yet, but the compiler
> generates a 
> warning when the struct's (uninitialized) field is being copied
> around
> 
> drivers/hid/intel-ish-hid/ipc/ipc.c: In function
> ‘write_ipc_from_queue’:
> drivers/hid/intel-ish-hid/ipc/ipc.c:316: warning:
> ‘ts_format.reserved’ may be used uninitialized in this function
> 
> Avoid this by force-initializing the field to zero.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/hid/intel-ish-hid/ipc/ipc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
> ish-hid/ipc/ipc.c
> index 0c9ac4d..417cd07 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -310,6 +310,7 @@ static int write_ipc_from_queue(struct
> ishtp_device *dev)
>                                                 ((uint32_t)tv_utc.tv_
> usec);
>                 ts_format.ts1_source = HOST_SYSTEM_TIME_USEC;
>                 ts_format.ts2_source = HOST_UTC_TIME_USEC;
> +               ts_format.reserved = 0;
>  
>                 time_update.primary_host_time = usec_system;
>                 time_update.secondary_host_time = usec_utc;
> -- 
> 1.9.2
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: intel-ish-hid: initialize ts_format.reserved Jiri Kosina <jikos@kernel.org> - 2016-11-05 16:20 +0100
  Re: [PATCH] HID: intel-ish-hid: initialize ts_format.reserved Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-11-05 18:10 +0100

csiph-web