Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1516241
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 |
| Date | 2016-11-07 16:10 +0100 |
| Message-ID | <sATIB-4Mo-21@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <syIeC-1oI-21@gated-at.bofh.it> <syIxX-1wq-1@gated-at.bofh.it> <sAQB4-2vw-17@gated-at.bofh.it> <sASjw-3Kx-21@gated-at.bofh.it> <sATpf-4qY-21@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Mon, Nov 07, 2016 at 02:40:47PM +0000, Marc Zyngier wrote:
> Sorry, missed this discussion entirely, as I was on the other side of
> the world. Not having a irq_set_type definitely seems odd (and
> configuring the trigger outside of the IRQ framework is quite ugly).
>
> Mika, can you please try the following (which is fully untested)?
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 48e6d84..822a6b8 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1868,6 +1868,15 @@ static int ioapic_set_affinity(struct irq_data *irq_data,
> return ret;
> }
>
> +static int ioapic_set_type(struct irq_data *data, unsigned int flow_type)
> +{
> + /*
> + * The IOAPIC has already been programmed behind our back,
> + * just pretend it all went OK, and too bad if it didn't.
> + */
> + return 0;
> +}
> +
> static struct irq_chip ioapic_chip __read_mostly = {
> .name = "IO-APIC",
> .irq_startup = startup_ioapic_irq,
> @@ -1876,6 +1885,7 @@ static struct irq_chip ioapic_chip __read_mostly = {
> .irq_ack = irq_chip_ack_parent,
> .irq_eoi = ioapic_ack_level,
> .irq_set_affinity = ioapic_set_affinity,
> + .irq_set_type = ioapic_set_type,
> .flags = IRQCHIP_SKIP_SET_WAKE,
> };
Thanks! This fixes the problem for me.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
BUG? genirq: irq 14 uses trigger mode 8; requested 0 Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-01 14:20 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Jon Hunter <jonathanh@nvidia.com> - 2016-11-01 15:30 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-01 15:50 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-07 12:50 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Jon Hunter <jonathanh@nvidia.com> - 2016-11-07 14:40 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Marc Zyngier <marc.zyngier@arm.com> - 2016-11-07 15:50 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-07 16:10 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Jon Hunter <jonathanh@nvidia.com> - 2016-11-07 17:00 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Thomas Gleixner <tglx@linutronix.de> - 2016-11-07 17:10 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Thomas Gleixner <tglx@linutronix.de> - 2016-11-07 20:40 +0100
Re: BUG? genirq: irq 14 uses trigger mode 8; requested 0 Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-08 10:20 +0100
[tip:irq/urgent] genirq: Use irq type from irqdata instead of irqdesc tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-11-08 15:30 +0100
csiph-web