Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516211

Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties

Show all headers | View raw

On Wed, 2016-11-02 at 11:55 +0000, Eugeniy Paltsev wrote:
> Hi Andy,
> Could you possibly tell me your ideas about these changes?
> Thanks.

Thanks for an update, but, please, answer to all my comments to your
patch v2. Either you are okay with them, then you didn't address few, or
you are not okay, I didn't get why. Deffer newer version until we get an
agreement on the implementation.

> 
> On Fri, 2016-10-28 at 18:59 +0300, Eugeniy Paltsev wrote:
> > This series is to address a proposal by Andy in these threads:
> > http://www.spinics.net/lists/dmaengine/msg11506.html
> > http://www.spinics.net/lists/dmaengine/msg11541.html
> > Split platform data to actual hardware properties, and platform
> > quirks.
> > Now we able to use quirks and hardware properties separately from
> > different sources (pdata, device tree or autoconfig registers)
> > 
> > Changes for v3:
> >  -   Split changes to separate patches.
> >  -   Add "DW_DMA_IS_LLP_SUPPORTED" flag and get rid of "dwc->nollp"
> >      as separate variable.
> >  -   Make "dw_dma_slave" documentation comments more clear about
> > quirks.
> >      "is_memcpy" and "is_private" are quirks, "is_nollp" is regular 
> >      pdata property.
> > 
> > Eugeniy Paltsev (3):
> >   dmaengine: DW DMAC: split pdata to hardware properties and
> > platform
> >     quirks
> >   dmaengine: DW DMAC: convert to unified device property API
> >   dmaengine: DW DMAC: move "nollp" to "dwc->flags"
> > 
> >  drivers/dma/dw/core.c                | 34 +++++++++++++----------
> >  drivers/dma/dw/platform.c            | 53 +++++++++++++++++++----
> > ---
> > ----------
> >  drivers/dma/dw/regs.h                |  2 +-
> >  include/linux/platform_data/dma-dw.h |  5 ++++
> >  4 files changed, 54 insertions(+), 40 deletions(-)
> > 
> 
> -- 
>  Paltsev Eugeniy

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-10-28 18:10 +0200
  [PATCH v3 2/3] dmaengine: DW DMAC: convert to unified device property API Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-10-28 18:10 +0200
  [PATCH v3 1/3] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-10-28 18:10 +0200
  [PATCH v3 3/3] dmaengine: DW DMAC: move "nollp" to "dwc->flags" Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-10-28 18:10 +0200
  Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware  properties Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-28 18:20 +0200
  Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware  properties Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-02 13:00 +0100
    Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware  properties Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-07 15:00 +0100
      Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware  properties Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-08 13:30 +0100
        Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware  properties Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-08 14:40 +0100
          Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware  properties Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-10 17:30 +0100
            Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-11-11 12:10 +0100

csiph-web