Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516092

Re: [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h

Show all headers | View raw

On Sun, 2016-11-06 at 12:45 +0900, Masahiro Yamada wrote:
> The header facilities_src.h is only included from gen_facilities.c
> and the tool is compiled with the following extra options:
> 
>     HOSTCFLAGS_gen_facilities.o += -Wall $(LINUXINCLUDE)
> 
> Please note $(LINUXINCLUDE) is expanded into build options including:
> 
>     -include $(srctree)/include/linux/kconfig.h
> 
> So, the Makefile always forces the tool to include kconfig.h, i.e.,
> the #include <linux/kconfig.h> directive in the header is redundant.

As far as I can see the only kernel header that gen_facilities.c is actually
interested in is autoconf.h. (autoconf.h will be included via in kconfig.h.)
So it seems the odd $(LINUXINCLUDE) variable in that Makefile could be
replaced with something like:
    -include $(srctree)/include/generated/autoconf.h


Paul Bolle

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-06 04:50 +0100
  Re: [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h>  from facilities_src.h Paul Bolle <pebolle@tiscali.nl> - 2016-11-07 14:00 +0100
    Re: [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-08 03:00 +0100
      Re: [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h>  from facilities_src.h Paul Bolle <pebolle@tiscali.nl> - 2016-11-08 10:20 +0100

csiph-web