Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469047

Re: [PATCH v1 00/10] Optimize sched avgs computation and implement flat util hierarchy

Show all headers | View raw

Hi Vincent,

On Tue, Aug 23, 2016 at 03:28:19PM +0200, Vincent Guittot wrote:
> I still wonder if using a flat util hierarchy is the right solution to
> solve this problem with utilization and task group. I have noticed
> exact same issues with load that generates weird task placement
> decision and i think that we should probably try to solve both wrong
> behavior with same mechanism. but this is not possible with flat
> hierarchy for load

I agree both util and load have the same hierarchical propagation
problem.

But util and load are different with respect to task group distribution
among CPUs and along hierarchical structure. Util is "fundamentally"
flat (CPU's util = tasks' util), so it's pretty natural as well as
simple to implement a flat hierarchy util. And because of that, I
feel util propagating up the hierarchical structure seems unnecessary.

It might be better to have a converged mechanism to solve both, but
it shouldn't be necessary. Right?

> Let me take an example.
> TA is a always running task on CPU1 in group /root/level1/
> TB wakes up on CPU0 and moves TA into group /root/level2/
> Even if TA stays on CPU1, runnable_load_avg of CPU1 root cfs rq will become 0.
> Then, TB forks a new task TC. TC will probably be schedule on CPU1
> because its root cfs_rq's runnable_load_avg is null and CPU1 is the
> next CPU after CPU0
> 
> Similar behavior can happen when TA migrates
> 
> Beside flat utilization consideration, i'm going to have a look at the

Many thanks.

Yuyang

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Yuyang Du <yuyang.du@intel.com> - 2016-08-23 09:30 +0200
  Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Vincent Guittot <vincent.guittot@linaro.org> - 2016-08-23 15:40 +0200
    Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Peter Zijlstra <peterz@infradead.org> - 2016-08-23 16:20 +0200
      Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Vincent Guittot <vincent.guittot@linaro.org> - 2016-08-23 16:50 +0200
        Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-08-23 17:50 +0200
        Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Morten Rasmussen <morten.rasmussen@arm.com> - 2016-08-24 11:10 +0200
          Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Vincent Guittot <vincent.guittot@linaro.org> - 2016-08-24 11:50 +0200
      Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Yuyang Du <yuyang.du@intel.com> - 2016-08-24 05:10 +0200
    Re: [PATCH v1 00/10] Optimize sched avgs computation and implement  flat util hierarchy Yuyang Du <yuyang.du@intel.com> - 2016-08-24 05:10 +0200

csiph-web