Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467859

Re: [v.1] clocksource:clps711x-timer:- Unmap a region obtained by remap

Show all headers | View raw

On Tuesday 16 August 2016 06:34 PM, Daniel Lezcano wrote:
> Hi Arvind,
>
> On 08/11/2016 07:41 PM, Arvind Yadav wrote:
>> iounmap frees the mapping when timer id is not matching.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
> Even if this fix is correct, it does actually rollback a minimalist part
> of what was done and only if the clock type is wrong. Can you properly
> handle the undo from the different init functions and regarding their
> success/error ?
>
> Thanks.
>
>    -- Daniel
As per your concern, I have done the changes.
please review it.

--Arvind
>>   drivers/clocksource/clps711x-timer.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clocksource/clps711x-timer.c b/drivers/clocksource/clps711x-timer.c
>> index 84aed78..deaca51 100644
>> --- a/drivers/clocksource/clps711x-timer.c
>> +++ b/drivers/clocksource/clps711x-timer.c
>> @@ -116,6 +116,7 @@ static int __init clps711x_timer_init(struct device_node *np)
>>   	case CLPS711X_CLKSRC_CLOCKEVENT:
>>   		return _clps711x_clkevt_init(clock, base, irq);
>>   	default:
>> +		iounmap(base);
>>   		return -EINVAL;
>>   	}
>>   }
>>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[v.1] clocksource:clps711x-timer:- Unmap a region obtained by remap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-08-12 16:50 +0200
  Re: [v.1] clocksource:clps711x-timer:- Unmap a region obtained by  remap Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-16 15:10 +0200
    Re: [v.1] clocksource:clps711x-timer:- Unmap a region obtained by  remap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-08-22 19:50 +0200

csiph-web