Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1467779

Re: [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for rcu_nocb_kthread

From Nikolay Borisov <n.borisov.lkml@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for rcu_nocb_kthread
Date 2016-08-22 18:40 +0200
Message-ID <s90qt-ft-9@gated-at.bofh.it> (permalink)
References <s8ZkK-81a-19@gated-at.bofh.it> <s8Zup-86b-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[SNIP]
> 
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> [ paulmck: Substituted cond_resched_rcu_qs for cond_resched. ]

This contradicts...

> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
>  kernel/rcu/tree_plugin.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 0082fce402a0..85c5a883c6e3 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -2173,6 +2173,7 @@ static int rcu_nocb_kthread(void *arg)
>  				cl++;
>  			c++;
>  			local_bh_enable();
> +			cond_resched_rcu_qs();

with what's here?
>  			list = next;
>  		}
>  		trace_rcu_batch_end(rdp->rsp->name, c, !!list, 0, 0, 1);
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH tip/core/rcu 0/5] Miscellaneous fixes for 4.9 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 17:30 +0200
  [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for rcu_nocb_kthread "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 17:40 +0200
    Re: [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for  rcu_nocb_kthread Nikolay Borisov <n.borisov.lkml@gmail.com> - 2016-08-22 18:40 +0200
      Re: [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for  rcu_nocb_kthread Nikolay Borisov <n.borisov.lkml@gmail.com> - 2016-08-22 18:50 +0200
      Re: [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for  rcu_nocb_kthread "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 18:50 +0200
  [PATCH tip/core/rcu 2/5] rcu: Use rcu_gp_kthread_wake() to wake up grace period kthreads again "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 17:40 +0200
  [PATCH tip/core/rcu 3/5] sched: Make wake_up_nohz_cpu() handle CPUs going offline "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 17:40 +0200
    Re: [PATCH tip/core/rcu 3/5] sched: Make wake_up_nohz_cpu() handle  CPUs going offline Wanpeng Li <kernellwp@gmail.com> - 2016-08-23 01:00 +0200
      Re: [PATCH tip/core/rcu 3/5] sched: Make wake_up_nohz_cpu() handle  CPUs going offline "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-23 02:50 +0200
        Re: [PATCH tip/core/rcu 3/5] sched: Make wake_up_nohz_cpu() handle  CPUs going offline Wanpeng Li <kernellwp@gmail.com> - 2016-08-23 02:50 +0200
  [PATCH tip/core/rcu 4/5] rcu: don't use modular infrastructure in non-modular code "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 17:40 +0200
  [PATCH tip/core/rcu 5/5] rcu: Avoid redundant quiescent-state chasing "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-08-22 17:40 +0200

csiph-web