Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1467678
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ? |
| Date | 2016-08-22 16:40 +0200 |
| Message-ID | <s8Yyl-7uQ-7@gated-at.bofh.it> (permalink) |
| References | <s8Y5k-7jf-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 22, 2016 at 03:07:44PM +0100, David Binderman wrote:
> Hello there,
>
> linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]:
> (style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always
> true
>
> Source code is
>
> if (pBtMgnt->ExtConfig.HCIExtensionVer < 1) {
> ....
> } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {
>
> Suggest remove second test.
patches are always welcome :)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-08-22 16:10 +0200 Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ? Greg KH <gregkh@linuxfoundation.org> - 2016-08-22 16:40 +0200 [PATCH] drivers: staging: rtl8723au: hal: Remove pointless test Matthias Beyer <mail@beyermatthias.de> - 2016-08-23 22:00 +0200 [PATCH] drivers: staging: rtl823au: hal: Remove pointless test Matthias Beyer <mail@beyermatthias.de> - 2016-08-23 22:00 +0200
csiph-web