Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467368

Re: [PATCH 2/2] ALSA: compress: Reduce the scope for two variables in snd_compr_set_params()

Show all headers | View raw

On Sun, Aug 21, 2016 at 04:36:22PM -0400, Julia Lawall wrote:
> 
> 
> On Sun, 21 Aug 2016, SF Markus Elfring wrote:
> 
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 21 Aug 2016 21:26:18 +0200
> >
> > Reduce the scope for the local variables to an if branch.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  sound/core/compress_offload.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> > index 583d407..b43aec5 100644
> > --- a/sound/core/compress_offload.c
> > +++ b/sound/core/compress_offload.c
> > @@ -545,14 +545,14 @@ static int snd_compress_check_input(struct snd_compr_params *params)
> >  static int
> >  snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg)
> >  {
> > -	struct snd_compr_params *params;
> > -	int retval;
> > -
> >  	if (stream->runtime->state == SNDRV_PCM_STATE_OPEN) {
> >  		/*
> >  		 * we should allow parameter change only when stream has been
> >  		 * opened not in other cases
> >  		 */
> > +		int retval;
> > +		struct snd_compr_params *params;
> 
> I don't like this at all.  Local variables should be at the top of the
> function, not hiding under 4 lines of comments in the middle of the code.

I agree with you this, it doesn't help IMO as well

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] ALSA: compress: Fine-tuning for snd_compr_set_params() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 21:50 +0200
  [PATCH 1/2] ALSA: compress: Use memdup_user() rather than duplicating  its implementation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 21:50 +0200
    Re: [PATCH 1/2] ALSA: compress: Use memdup_user() rather than  duplicating its implementation Vinod Koul <vinod.koul@intel.com> - 2016-08-22 07:00 +0200
    Re: [alsa-devel] [PATCH 1/2] ALSA: compress: Use memdup_user() rather than duplicating its implementation Takashi Iwai <tiwai@suse.de> - 2016-08-22 14:10 +0200
      Re: [alsa-devel] [PATCH 1/2] ALSA: compress: Use memdup_user()  rather than duplicating its implementation Vinod Koul <vinod.koul@intel.com> - 2016-08-23 05:50 +0200
  [PATCH 2/2] ALSA: compress: Reduce the scope for two variables in  snd_compr_set_params() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-21 21:50 +0200
    Re: [PATCH 2/2] ALSA: compress: Reduce the scope for two variables  in snd_compr_set_params() Joe Perches <joe@perches.com> - 2016-08-21 22:00 +0200
      [PATCH v2 0/2] ALSA: compress: Fine-tuning for snd_compr_set_params() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-22 10:40 +0200
        [PATCH v2 1/2] ALSA: compress: Restructure source code around an if  statement in snd_compr_set_params() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-22 10:40 +0200
        [PATCH v2 2/2] ALSA: compress: Use memdup_user() rather than  duplicating its implementation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-22 10:50 +0200
        Re: [PATCH v2 0/2] ALSA: compress: Fine-tuning for  snd_compr_set_params() Vinod Koul <vinod.koul@intel.com> - 2016-08-23 06:00 +0200
    Re: [PATCH 2/2] ALSA: compress: Reduce the scope for two variables  in snd_compr_set_params() Julia Lawall <julia.lawall@lip6.fr> - 2016-08-21 22:40 +0200
      Re: [PATCH 2/2] ALSA: compress: Reduce the scope for two variables  in snd_compr_set_params() Vinod Koul <vinod.koul@intel.com> - 2016-08-22 07:00 +0200
    Re: [PATCH 2/2] ALSA: compress: Reduce the scope for two variables  in snd_compr_set_params() walter harms <wharms@bfs.de> - 2016-08-22 09:30 +0200

csiph-web