Re: [PATCH v2] staging: esp8089: add new driver

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] staging: esp8089: add new driver
Date	2016-08-21 23:30 +0200
Message-ID	<s8Itz-5Ge-3@gated-at.bofh.it> (permalink)
References	<rM9Cy-1EU-31@gated-at.bofh.it> <rM9Cy-1EU-29@gated-at.bofh.it> <rMvMK-7AG-27@gated-at.bofh.it> <rMvMK-7AG-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 21, 2016 at 08:17:14AM -0700, Greg KH wrote:
> On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote:
> > The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source.
> > I cannot promise the code style (although I did indent -kr -i8).
> > I cannot also promise the effect.
> 
> I don't understand this at all, sorry.
> 
> Why should we accept this driver?  Who is going to maintain it?  What
> needs to be done to it?
> 
> And why are you top-posting?  :)

Dropping from my queue due to lack of a response.

If you fix it up, please resend it, but we need the answers to the above
questions if you do so.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] staging: esp8089: add new driver Greg KH <gregkh@linuxfoundation.org> - 2016-08-21 23:30 +0200

csiph-web