[Regression?] Commit cb4f71c429 deliberately changes order of network interfaces

From	Ralph Sennhauser <ralph.sennhauser@gmail.com>
Newsgroups	linux.kernel
Subject	[Regression?] Commit cb4f71c429 deliberately changes order of network interfaces
Date	2016-08-21 15:20 +0200
Message-ID	<s8APn-Of-1@gated-at.bofh.it> (permalink)
Organization	none

Show all headers | View raw

Dear List, Thomas, Gregory

Commit cb4f71c4298853db0c6751b1209e4535956f136c changes the order of
the network interfaces for armada-38x. As a special exception to the
"order by register address" rule says the comment in the dtsi. The
commit messages even calls it a violation.

I can't remember having owned a device were the internal and external
numbering actually matched, so the important bit for me is whatever the
order is it should remain constant.

Distributions like OpenWrt have to fix their code when moving from 4.4
currently to past 4.6 [1]. Worse the so called "wrong ordering" is
actually documented [2]. There are likely more victims out there. In
case it goes unnoticed by the distribution the users lan becomes wan
and vice versa.

It's unfortunate that this commit is already in stable 4.6 and 4.7.

What is your take on this? Should the commit be reverted?

Regards
Ralph

[1]
https://github.com/openwrt/openwrt/blob/master/target/linux/mvebu/base-files/etc/board.d/02_network
[2] https://wiki.openwrt.org/toh/linksys/wrt1x00ac_series#switch_layout

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2016-08-21 15:20 +0200
  Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-08-24 17:00 +0200
    Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces lsorense@csclub.uwaterloo.ca (Lennart Sorensen) - 2016-08-24 18:40 +0200
      Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-08-24 18:50 +0200
        Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces lsorense@csclub.uwaterloo.ca (Lennart Sorensen) - 2016-08-24 19:20 +0200
          Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces lsorense@csclub.uwaterloo.ca (Lennart Sorensen) - 2016-08-24 20:50 +0200
    Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2016-08-24 19:20 +0200
      Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces lsorense@csclub.uwaterloo.ca (Lennart Sorensen) - 2016-08-24 20:10 +0200
        Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-08-24 20:20 +0200
          Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces lsorense@csclub.uwaterloo.ca (Lennart Sorensen) - 2016-08-24 20:30 +0200
            Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-08-24 22:10 +0200
              Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces lsorense@csclub.uwaterloo.ca (Lennart Sorensen) - 2016-08-24 23:00 +0200
      Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-08-24 20:50 +0200
        Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2016-08-24 22:50 +0200
          Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Jason Cooper <jason@lakedaemon.net> - 2016-08-24 23:50 +0200
            Re: [Regression?] Commit cb4f71c429 deliberately changes order of  network interfaces Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2016-08-25 09:40 +0200

csiph-web