Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1464333

Re: [PATCH v2] clk: max77686: Migrate to clk_hw based OF and registration APIs

Show all headers | View raw

On 08/17/2016 12:38 AM, Stephen Boyd wrote:
> Now that we have clk_hw based provider APIs to register clks, we
> can get rid of struct clk pointers while registering clks in
> these drivers, allowing us to move closer to a clear split of
> consumer and provider clk APIs.
> 
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
>  drivers/clk/clk-max77686.c | 42 +++++++++++++++++++++---------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)

Looks correct. The pr_err() could be replaced to dev_err() but first
pointer to dev should be stored... so this may be fixed on different patch.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] clk: max77686: Migrate to clk_hw based OF and registration APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-08-17 00:50 +0200
  Re: [PATCH v2] clk: max77686: Migrate to clk_hw based OF and  registration APIs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-17 05:10 +0200
  Re: [PATCH v2] clk: max77686: Migrate to clk_hw based OF and  registration APIs Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-17 08:10 +0200
  Re: [PATCH v2] clk: max77686: Migrate to clk_hw based OF and  registration APIs Stephen Boyd <sboyd@codeaurora.org> - 2016-08-19 03:30 +0200

csiph-web