Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1463197
| From | Arend Van Spriel <arend.vanspriel@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface |
| Date | 2016-08-15 23:50 +0200 |
| Message-ID | <s6xVD-2Er-11@gated-at.bofh.it> (permalink) |
| References | <s6mGR-3T5-7@gated-at.bofh.it> <s6mGR-3T5-9@gated-at.bofh.it> <s6nCV-4sn-5@gated-at.bofh.it> <s6nMB-4vM-5@gated-at.bofh.it> <s6oIG-56q-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 15-8-2016 13:52, Rafał Miłecki wrote:
> On 15 August 2016 at 12:57, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Rafał Miłecki <zajec5@gmail.com> writes:
>>
>>>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
>>>
>>> Fixes: a63b09872c1d ("brcmfmac: delete interface directly in code that sent fw request")
>>> Acked-by: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> Kalle: I'm acking this as bugfix for 4.8 release.
>>
>> Ok. I'll wait few days for more comments before I apply this.
>
> Sure.
>
>
>> (I assume you are talking only about patch 1)
>
> Yes, I'll leave mutex vs. spinlock to the experts :)
Don't know who the experts are. Surely not me :-p
I made an uneducated design decision using a mutex for this. The
reasoning for using a regular spinlock make sense. So I will go and ack
that patch.
Regards,
Arend
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface Masami Hiramatsu <mhiramat@kernel.org> - 2016-08-15 11:50 +0200
Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface Rafał Miłecki <zajec5@gmail.com> - 2016-08-15 12:50 +0200
Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface Kalle Valo <kvalo@codeaurora.org> - 2016-08-15 13:00 +0200
Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface Rafał Miłecki <zajec5@gmail.com> - 2016-08-15 14:00 +0200
Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-08-15 23:50 +0200
Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface Masami Hiramatsu <mhiramat@kernel.org> - 2016-08-16 04:30 +0200
Re: [BUGFIX, 1/2] brcmfmac: Check rtnl_lock is locked when removing interface Kalle Valo <kvalo@codeaurora.org> - 2016-08-24 15:20 +0200
csiph-web