Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1463137

[PATCH v2 0/3] 'slot' can be NULL in radix_tree_next_slot()

Show all headers | View raw

This adds comments above radix_tree_next_slot() documenting the combination
of factors that prevent us from dereferencing a NULL 'slot' pointer.  It
also adds a radix tree unit test so that we can easily catch any unhandled
NULL pointer issues with radix_tree_next_slot().

Changes from V1:
 - Instead of adding an explicit check for 'slot' being NULL at the
   beginning of radix_tree_next_slot(), document what factors are keeping
   us safe instead.  (Konstantin)

Ross Zwisler (3):
  radix-tree: 'slot' can be NULL in radix_tree_next_slot()
  radix-tree tests: add iteration test
  radix-tree tests: properly initialize mutex

 include/linux/radix-tree.h                 |   8 ++
 tools/testing/radix-tree/Makefile          |   3 +-
 tools/testing/radix-tree/iteration_check.c | 180 +++++++++++++++++++++++++++++
 tools/testing/radix-tree/main.c            |   1 +
 tools/testing/radix-tree/regression1.c     |   2 +-
 tools/testing/radix-tree/test.h            |   1 +
 6 files changed, 193 insertions(+), 2 deletions(-)
 create mode 100644 tools/testing/radix-tree/iteration_check.c

-- 
2.9.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 0/3] 'slot' can be NULL in radix_tree_next_slot() Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-08-15 21:50 +0200

csiph-web