Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462900

Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip

Show all headers | View raw

Hi Zubair,

On Mon, Aug 15, 2016 at 02:55:27PM +0100, Zubair Lutfullah Kakakhel wrote:
> The Xilinx AXI Interrupt Controller IP block is used by the MIPS
> based xilfpga platform.
> 
> Move the interrupt controller code out of arch/microblaze so that
> it can be used by everyone
> 
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> ---
>  arch/microblaze/Kconfig                                       | 1 +
>  arch/microblaze/kernel/Makefile                               | 2 +-
>  drivers/irqchip/Kconfig                                       | 4 ++++
>  drivers/irqchip/Makefile                                      | 1 +
>  arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c | 0
>  5 files changed, 7 insertions(+), 1 deletion(-)
>  rename arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c (100%)

When you send the next version, please disable rename detection.  The
driver looks pretty straight forward, but I'd like to take the
opportunity to clean up the abstraction around read and write.  As well
as making it easier for everyone to review on-list.

thx,

Jason.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] MIPS: xilfpga: Intc and various peripherals Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:00 +0200
  [PATCH 3/9] MIPS: xilfpga: Use irqchip_init instead of the legacy way Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:00 +0200
  [PATCH 6/9] MIPS: Xilfpga: Add DT node for AXI I2C Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:30 +0200
  [PATCH 5/9] MIPS: xilfpga: Update DT node and specify uart irq Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:30 +0200
  [PATCH 8/9] MIPS: xilfpga: Add DT node for AXI emaclite Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:30 +0200
    Re: [PATCH 8/9] MIPS: xilfpga: Add DT node for AXI emaclite Jason Cooper <jason@lakedaemon.net> - 2016-08-15 17:20 +0200
      Re: [PATCH 8/9] MIPS: xilfpga: Add DT node for AXI emaclite Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-18 12:20 +0200
  [PATCH 9/9] MIPS: xilfpga: Update defconfig Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:30 +0200
  [PATCH 4/9] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:30 +0200
    Re: [PATCH 4/9] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller Jason Cooper <jason@lakedaemon.net> - 2016-08-15 17:20 +0200
  [PATCH 7/9] net: ethernet: xilinx: Enable emaclite for MIPS Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:30 +0200
  [PATCH 2/9] irqchip: xilinx: Add support for parent intc Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:30 +0200
  [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-15 16:40 +0200
    Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip Jason Cooper <jason@lakedaemon.net> - 2016-08-15 17:10 +0200
    Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip Jason Cooper <jason@lakedaemon.net> - 2016-08-15 17:30 +0200
      Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> - 2016-08-18 12:00 +0200

csiph-web