Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1462662
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/3] arm64: vdso: constify vm_special_mapping used for aarch32 vectors page |
| Date | 2016-08-15 11:20 +0200 |
| Message-ID | <s6mdP-3HY-3@gated-at.bofh.it> (permalink) |
| References | <s6k2l-290-9@gated-at.bofh.it> <s6k2m-290-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 15, 2016 at 02:45:45PM +0800, Jisheng Zhang wrote:
> The vm_special_mapping spec which is used for aarch32 vectors page is
> never modified, so mark it as const.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
I see that this is never deliberately modified before being passed to
_install_special_mapping, which takes it as a const pointer. So this looks good
to me:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/kernel/vdso.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> index e320e8f..10ad8ab 100644
> --- a/arch/arm64/kernel/vdso.c
> +++ b/arch/arm64/kernel/vdso.c
> @@ -88,7 +88,7 @@ int aarch32_setup_vectors_page(struct linux_binprm *bprm, int uses_interp)
> {
> struct mm_struct *mm = current->mm;
> unsigned long addr = AARCH32_VECTORS_BASE;
> - static struct vm_special_mapping spec = {
> + static const struct vm_special_mapping spec = {
> .name = "[vectors]",
> .pages = vectors_page,
>
> --
> 2.8.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/3] arm64: put objects into proper sections Jisheng Zhang <jszhang@marvell.com> - 2016-08-15 09:00 +0200
[PATCH v4 1/3] arm64: vdso: add __init section marker to alloc_vectors_page Jisheng Zhang <jszhang@marvell.com> - 2016-08-15 09:00 +0200
Re: [PATCH v4 1/3] arm64: vdso: add __init section marker to alloc_vectors_page Mark Rutland <mark.rutland@arm.com> - 2016-08-15 11:20 +0200
[PATCH v4 2/3] arm64: vdso: constify vm_special_mapping used for aarch32 vectors page Jisheng Zhang <jszhang@marvell.com> - 2016-08-15 09:00 +0200
Re: [PATCH v4 2/3] arm64: vdso: constify vm_special_mapping used for aarch32 vectors page Mark Rutland <mark.rutland@arm.com> - 2016-08-15 11:20 +0200
[PATCH v4 3/3] arm64: apply __ro_after_init to some objects Jisheng Zhang <jszhang@marvell.com> - 2016-08-15 09:00 +0200
Re: [PATCH v4 3/3] arm64: apply __ro_after_init to some objects Mark Rutland <mark.rutland@arm.com> - 2016-08-15 11:40 +0200
csiph-web