Re: Why do we need reset_control_get_optional() ?

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: Why do we need reset_control_get_optional() ?
Date	2016-08-16 11:50 +0200
Message-ID	<s6Jap-1oP-9@gated-at.bofh.it> (permalink)
References	<rY3i1-2br-15@gated-at.bofh.it> <s0ITM-79Q-9@gated-at.bofh.it> <s2J8Z-5cv-3@gated-at.bofh.it> <s2Po6-Va-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,



2016-08-06 0:35 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:

>
> config RESET_FOO
>         bool "FOO reset controller" if COMPILE_TEST && !ARCH_FOO
>         default ARCH_FOO
>
> then I think we get both: you won't be able to turn it off
> but also get the build testing.


This looks good to me, too.
I do not know if we need "&& !ARCH_FOO", though.

When we are compile-testing, we do not care if it works on run-time,
so perhaps it makes sense to allow to enable/disable RESET_FOO
regardless ARCH_FOO.


Philipp also agreed, so I guess the permission for this rework
is granted.
Would you do it?



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: Why do we need reset_control_get_optional() ? Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-16 11:50 +0200
  Re: Why do we need reset_control_get_optional() ? Philipp Zabel <p.zabel@pengutronix.de> - 2016-08-24 16:00 +0200

csiph-web