Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462293

Re: [PATCH] CodingStyle: Clarify and complete chapter 7

Show all headers | View raw

On Mon, 25 Jul 2016 14:29:06 +0200
Jean Delvare <jdelvare@suse.de> wrote:

> Chapter 7 (Centralized exiting of functions) of the coding style
> documentation is unclear at times, and lacks some information (such
> as the possibility to indent labels with a single space.) Clarify and
> complete it.

OK, I've applied this (finally) to the docs tree, sorry for sitting on it
for so long.  One question, though...

>  A common type of bug to be aware of is "one err bugs" which look like this:
>  
> -	err:
> +	 err:
>  		kfree(foo->bar);
>  		kfree(foo);
>  		return ret;
>  
>  The bug in this code is that on some exit paths "foo" is NULL.  Normally the

...except that kfree() can handle null pointers just fine, so this isn't
actually a bug, right?  Someday when somebody has time it would be good to
come up with a better example.

Thanks,

jon

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] CodingStyle: Clarify and complete chapter 7 Jonathan Corbet <corbet@lwn.net> - 2016-08-14 20:40 +0200
  Re: [PATCH] CodingStyle: Clarify and complete chapter 7 Mark D Rustad <mrustad@gmail.com> - 2016-08-14 22:20 +0200
    Re: [PATCH] CodingStyle: Clarify and complete chapter 7 Jonathan Corbet <corbet@lwn.net> - 2016-08-14 22:50 +0200
    Re: CodingStyle: Clarify and complete chapter 7 SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-15 17:40 +0200

csiph-web