Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1459290
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode |
| Date | 2016-08-10 06:40 +0200 |
| Message-ID | <s4tt7-oV-13@gated-at.bofh.it> (permalink) |
| References | <s41Qd-7Ui-5@gated-at.bofh.it> <s41Qd-7Ui-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon 08 Aug 16:03 PDT 2016, John Stultz wrote:
[..]
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
[..]
> memory@0 {
> device_type = "memory";
> reg = <0x00000000 0x00000000 0x00000000 0x05e00000>,
> - <0x00000000 0x05f00000 0x00000000 0x00eff000>,
> + <0x00000000 0x05f00000 0x00000000 0x00001000>,
> + <0x00000000 0x05f02000 0x00000000 0x00efd000>,
> <0x00000000 0x06e00000 0x00000000 0x0060f000>,
> <0x00000000 0x07410000 0x00000000 0x36bf0000>;
> };
As I said when talked about this, I don't think you should punch holes
in the /memory node, but rather add these regions as no-map in a
/reserved-memory node. But that's a unrelated matter.
>
> + reboot-mode-syscon@5f01000 {
> + compatible = "syscon", "simple-mfd";
> + reg = <0x0 0x05f01000 0x0 0x00001000>;
> +
> + reboot-mode@0 {
Drop the @0
Other than that:
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> + compatible = "syscon-reboot-mode";
> + offset = <0x0>;
> +
> + mode-normal = <0x77665501>;
> + mode-bootloader = <0x77665500>;
> + mode-recovery = <0x77665502>;
> + };
> + };
> +
> soc {
> spi0: spi@f7106000 {
> status = "ok";
Regards,
Bjorn
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode John Stultz <john.stultz@linaro.org> - 2016-08-09 01:10 +0200
Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-10 06:40 +0200
Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode John Stultz <john.stultz@linaro.org> - 2016-08-10 07:00 +0200
csiph-web