Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries

From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries
Date	2016-08-11 16:30 +0200
Message-ID	<s4Z9E-4XM-1@gated-at.bofh.it> (permalink)
References	<s41Qd-7Ui-11@gated-at.bofh.it> <s41Qd-7Ui-9@gated-at.bofh.it> <s4GTp-n4-55@gated-at.bofh.it> <s4H36-I0-89@gated-at.bofh.it> <s4TQC-1tP-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/11/16 at 10:46am, Ingo Molnar wrote:
> > > > -		count = madt_proc[1].count;
> > > > +		count = madt_proc[0].count;
> > > > +		x2count = madt_proc[1].count;
> > > >  	}
> > > >  	if (!count && !x2count) {
> >           ~~~~~~~~~~~~~~~~~~~~~
> > I mean here the value checking won't be impacted by the wrong
> > assignment.
> 
> Indeed!
> 
> Mind putting that into the changelog? Something like:
> 
> "By pure accident the bug makes no functional difference, because the only 
>  expression where we are using these values is (!count && !x2count), in which
>  the variables are interchangeable, but it makes sense to fix the bug 
>  nevertheless."

Sure, this is much clearer. Will use this and repost. Thanks a lot, will
try to do each post using patch log like this.

Thanks
Baoquan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle  apic/x2apic entries Ingo Molnar <mingo@kernel.org> - 2016-08-11 10:50 +0200
  Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle  apic/x2apic entries Baoquan He <bhe@redhat.com> - 2016-08-11 16:30 +0200

csiph-web