Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1460125
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers |
| Date | 2016-08-11 03:10 +0200 |
| Message-ID | <s4MFr-4ne-3@gated-at.bofh.it> (permalink) |
| References | <s4Jey-29X-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Wed, 10 Aug 2016 20:02:53 +0300
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 0805855..5caef77 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -732,6 +732,11 @@ static void cpsw_rx_handler(void *token, int len, int status)
> netif_receive_skb(skb);
> ndev->stats.rx_bytes += len;
> ndev->stats.rx_packets++;
> + /* SKB pointer will be stored in CPPI RAM (SRAM) which belongs
> + * to MMIO space, as result false positive memory leak report
> + * will be generated.
> + */
> + kmemleak_not_leak(new_skb);
> } else {
> ndev->stats.rx_dropped++;
> new_skb = skb;
There is already a kmemleak_not_leak() statement here in the current
driver.
Please always develop and generate patches against current sources.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers Grygorii Strashko <grygorii.strashko@ti.com> - 2016-08-10 23:30 +0200
Re: [PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers David Miller <davem@davemloft.net> - 2016-08-11 03:10 +0200
Re: [PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers Grygorii Strashko <grygorii.strashko@ti.com> - 2016-08-11 14:40 +0200
csiph-web