Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457848

Re: [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux()

Show all headers | View raw

On 8 August 2016 at 04:49, Alexander Shishkin
<alexander.shishkin@linux.intel.com> wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
>
>> On Thu, Jul 28, 2016 at 03:42:19PM -0600, Mathieu Poirier wrote:
>>> Some information, like driver specific configuration, is found
>>> in the hw_perf_event  structure.  As such pass a 'struct perf_event'
>>> to function setup_aux() rather than just the CPU number so that
>>> individual drivers can make the right configuration when setting
>>> up a session.
>>>
>>> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>>> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
>>
>> Yeah, no objection to this.
>
> Sure, but I'd like a commit message that actually describes *what*
> information and *why*.

Sure, I'll make it more explicit in the next revision.

Mathieu

>
> Regards,
> --
> Alex

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 0/6] perf: Driver specific configuration for PMU Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-28 23:50 +0200
  [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-28 23:50 +0200
    Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific  configuration Peter Zijlstra <peterz@infradead.org> - 2016-08-04 19:00 +0200
      Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-05 17:40 +0200
        Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific  configuration Peter Zijlstra <peterz@infradead.org> - 2016-08-05 18:00 +0200
    Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific  configuration Peter Zijlstra <peterz@infradead.org> - 2016-08-04 19:10 +0200
      Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-05 17:50 +0200
        Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific  configuration Peter Zijlstra <peterz@infradead.org> - 2016-08-05 18:00 +0200
  [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-28 23:50 +0200
    Re: [PATCH V3 2/6] perf: Passing struct perf_event to function  setup_aux() Peter Zijlstra <peterz@infradead.org> - 2016-08-04 19:20 +0200
      Re: [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-08 13:00 +0200
        Re: [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-08 16:50 +0200
  [PATCH V3 6/6] coresight: etm-perf: incorporating sink definition from cmd line Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-28 23:50 +0200
  [PATCH V3 5/6] coresight: adding sink parameter to function coresight_build_path() Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-28 23:50 +0200
  [PATCH V3 4/6] perf tools: pushing driver configuration down to the kernel Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-28 23:50 +0200
    Re: [PATCH V3 4/6] perf tools: pushing driver configuration down to  the kernel Jiri Olsa <jolsa@redhat.com> - 2016-07-31 14:10 +0200
      Re: [PATCH V3 4/6] perf tools: pushing driver configuration down to  the kernel Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-08-04 00:00 +0200
  [PATCH V3 3/6] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-07-28 23:50 +0200
    Re: [PATCH V3 3/6] perf tools: add infrastructure for PMU specific  configuration Jiri Olsa <jolsa@redhat.com> - 2016-07-31 14:20 +0200

csiph-web