Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456480
| From | Matt Fleming <matt@codeblueprint.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/6] efi: Retrieve Apple device properties |
| Date | 2016-08-04 17:20 +0200 |
| Message-ID | <s2sBc-2wI-13@gated-at.bofh.it> (permalink) |
| References | <rZvcd-7cz-7@gated-at.bofh.it> <rZvce-7cz-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 28 Jul, at 02:25:41AM, Lukas Wunner wrote:
>
> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> index ff574da..7262ee4 100644
> --- a/arch/x86/boot/compressed/eboot.c
> +++ b/arch/x86/boot/compressed/eboot.c
> @@ -571,6 +571,55 @@ free_handle:
> efi_call_early(free_pool, pci_handle);
> }
>
> +static void retrieve_apple_device_properties(struct boot_params *params)
> +{
> + efi_guid_t guid = APPLE_PROPERTIES_PROTOCOL_GUID;
> + struct setup_data *data, *new;
> + efi_status_t status;
> + void *properties;
> + u32 size = 0;
> +
> + status = efi_early->call(
> + (unsigned long)sys_table->boottime->locate_protocol,
> + &guid, NULL, &properties);
> + if (status != EFI_SUCCESS)
> + return;
> +
> + do {
> + status = efi_call_early(allocate_pool, EFI_LOADER_DATA,
> + size + sizeof(struct setup_data), &new);
> + if (status != EFI_SUCCESS) {
> + efi_printk(sys_table,
> + "Failed to alloc mem for properties\n");
> + return;
> + }
> + status = efi_early->call(efi_early->is64 ?
> + ((apple_properties_protocol_64 *)properties)->get_all :
> + ((apple_properties_protocol_32 *)properties)->get_all,
> + properties, new->data, &size);
> + if (status == EFI_BUFFER_TOO_SMALL)
> + efi_call_early(free_pool, new);
> + } while (status == EFI_BUFFER_TOO_SMALL);
Is this looping really required? Do we not know ahead of time what we
expect the size to be? Writing this as a potentially infinite loop (if
broken firmware always returns EFI_BUFFER_TOO_SMALL) is a bad idea.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/6] efi: Retrieve Apple device properties Lukas Wunner <lukas@wunner.de> - 2016-07-27 13:30 +0200
Re: [PATCH 1/6] efi: Retrieve Apple device properties Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-04 17:20 +0200
Re: [PATCH 1/6] efi: Retrieve Apple device properties Lukas Wunner <lukas@wunner.de> - 2016-08-05 13:50 +0200
Re: [PATCH 1/6] efi: Retrieve Apple device properties Matt Fleming <matt@codeblueprint.co.uk> - 2016-08-05 14:10 +0200
csiph-web