Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457166

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

From Johannes Berg <johannes@sipsolutions.net>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput
Date 2016-08-05 17:40 +0200
Message-ID <s2Po5-Va-3@gated-at.bofh.it> (permalink)
References <s2q6m-DV-45@gated-at.bofh.it> <s2q6m-DV-43@gated-at.bofh.it> <s2Mqd-7rU-9@gated-at.bofh.it> <s2Po5-Va-5@gated-at.bofh.it> <s2Nmi-85e-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-08-05 at 13:25 +0000, Altshul, Maxim wrote:
> Hi,
> 1) Sorry about the change log, I will try to be clearer next time.

Just mention something about how the bug happens please, at least.

> 2+3) The issue is not that the station is not known, it's that
> wl_sta->wl was null. 
> wl member is now completely removed from wl_sta (PATCH 2/2) and hw is
> sent directly from mac80211 to the driver (so it can get hw->priv).

Right, I understand that wl_sta->wl was NULL. But the driver must have
some code to assign wl_sta->wl, right? And that would be called in
add_sta or sta_state. Thus the reason for the crash would be that the
station wasn't actually known to the driver yet.

Even if that wasn't quite the reason here, I think we need to take it
into account and check sta->uploaded before calling the driver, so I'd
like you to submit a patch for that.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput Maxim Altshul <maxim.altshul@ti.com> - 2016-08-04 14:40 +0200
  [PATCH 2/2] wlcore: Remove wl pointer from wl_sta structure Maxim Altshul <maxim.altshul@ti.com> - 2016-08-04 14:50 +0200
    Re: [PATCH 2/2] wlcore: Remove wl pointer from wl_sta structure John Stultz <john.stultz@linaro.org> - 2016-08-04 23:40 +0200
  Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput John Stultz <john.stultz@linaro.org> - 2016-08-04 23:40 +0200
    Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 07:50 +0200
      Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput John Stultz <john.stultz@linaro.org> - 2016-08-05 08:10 +0200
  Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 14:30 +0200
    RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput "Altshul, Maxim" <maxim.altshul@ti.com> - 2016-08-05 15:30 +0200
      Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 17:40 +0200
        RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput "Altshul, Maxim" <maxim.altshul@ti.com> - 2016-08-07 15:50 +0200
          Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput Johannes Berg <johannes@sipsolutions.net> - 2016-08-08 08:20 +0200
            RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput "Altshul, Maxim" <maxim.altshul@ti.com> - 2016-08-08 12:50 +0200
              Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput Johannes Berg <johannes@sipsolutions.net> - 2016-08-09 10:00 +0200
                RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput "Altshul, Maxim" <maxim.altshul@ti.com> - 2016-08-10 23:00 +0200
  Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to  get_expected_throughput Johannes Berg <johannes@sipsolutions.net> - 2016-08-05 14:30 +0200

csiph-web