Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
Date	2016-08-05 05:50 +0200
Message-ID	<s2EiZ-2cn-1@gated-at.bofh.it> (permalink)
References	<s2Ap4-8cT-7@gated-at.bofh.it> <s2Ap4-8cT-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

York Sun <york.sun@nxp.com> writes:

> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
>
> ---
> Change log
>   v3: Change subject tag
>   v2: no change
>
>  arch/powerpc/kernel/pci-common.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
> index 0f7a60f..86bc484 100644
> --- a/arch/powerpc/kernel/pci-common.c
> +++ b/arch/powerpc/kernel/pci-common.c
> @@ -226,6 +226,7 @@ struct pci_controller* pci_find_hose_for_OF_device(struct device_node* node)
>  	}
>  	return NULL;
>  }
> +EXPORT_SYMBOL(pci_find_hose_for_OF_device);
>  
>  /*
>   * Reads the interrupt pin to determine if interrupt is use by card.
> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>  {
>  	return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
>  }
> +EXPORT_SYMBOL(early_find_capability);

Does the driver really need to use these routines? They're meant for use
early in boot, before PCI is setup.

AFAICS this is just a regular driver, so when it's probed the PCI
devices should have already been scanned. In which case pci_get_device()
could work couldn't it? (I see other edac drivers doing that).

cheers

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac Michael Ellerman <mpe@ellerman.id.au> - 2016-08-05 05:50 +0200
  Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac Borislav Petkov <bp@alien8.de> - 2016-08-05 09:10 +0200
    Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac Johannes Thumshirn <jthumshirn@suse.de> - 2016-08-05 09:20 +0200
    Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac york sun <york.sun@nxp.com> - 2016-08-08 19:30 +0200
  Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac york sun <york.sun@nxp.com> - 2016-08-05 23:10 +0200
  Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac Scott Wood <oss@buserror.net> - 2016-08-05 23:20 +0200
    Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac Scott Wood <oss@buserror.net> - 2016-08-06 00:00 +0200
    Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac york sun <york.sun@nxp.com> - 2016-08-06 00:00 +0200
  Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for  mpc85xx_edac york sun <york.sun@nxp.com> - 2016-08-06 22:20 +0200

csiph-web