Re: [PATCH] MIPS: Loongson1B: Provide DMA filter callbacks via platform data

From	Ralf Baechle <ralf@linux-mips.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MIPS: Loongson1B: Provide DMA filter callbacks via platform data
Date	2016-08-03 08:20 +0200
Message-ID	<s1XH3-72D-7@gated-at.bofh.it> (permalink)
References	<rDJcj-7iX-21@gated-at.bofh.it> <rDJcj-7iX-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, May 28, 2016 at 05:51:52PM +0800, Keguang Zhang wrote:

> diff --git a/arch/mips/include/asm/mach-loongson32/nand.h b/arch/mips/include/asm/mach-loongson32/nand.h
> index e274912..a1f8704 100644
> --- a/arch/mips/include/asm/mach-loongson32/nand.h
> +++ b/arch/mips/include/asm/mach-loongson32/nand.h
> @@ -21,10 +21,9 @@ struct plat_ls1x_nand {
>  
>  	int hold_cycle;
>  	int wait_cycle;
> +	bool (*dma_filter)(struct dma_chan *chan, void *param);
>  };
>  
>  extern struct plat_ls1x_nand ls1b_nand_pdata;
>  
> -bool ls1x_dma_filter_fn(struct dma_chan *chan, void *param);
> -
>  #endif /* __ASM_MACH_LOONGSON32_NAND_H */
> diff --git a/arch/mips/loongson32/ls1b/board.c b/arch/mips/loongson32/ls1b/board.c
> index 38a1d40..0a57337 100644
> --- a/arch/mips/loongson32/ls1b/board.c
> +++ b/arch/mips/loongson32/ls1b/board.c
> @@ -38,6 +38,7 @@ struct plat_ls1x_nand ls1x_nand_pdata = {
>  	.nr_parts	= ARRAY_SIZE(ls1x_nand_parts),
>  	.hold_cycle	= 0x2,
>  	.wait_cycle	= 0xc,
> +	.dma_filter	= ls1x_dma_filter,
>  };

Without the DMA driver which Vinod has requested changes for this
patch will result in build errors.  It will also result in a build
error if CONFIG_LOONGSON1_DMA is disabled.

  Ralf

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] MIPS: Loongson1B: Provide DMA filter callbacks via  platform data Ralf Baechle <ralf@linux-mips.org> - 2016-08-03 08:20 +0200

csiph-web