Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455351

[PATCH 0091/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/block/rsxx/dev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/block/rsxx/dev.c b/drivers/block/rsxx/dev.c
index e1b8b70..fc11649 100644
--- a/drivers/block/rsxx/dev.c
+++ b/drivers/block/rsxx/dev.c
@@ -38,7 +38,7 @@
 #include "rsxx_priv.h"
 
 static unsigned int blkdev_minors = 64;
-module_param(blkdev_minors, uint, 0444);
+module_param(blkdev_minors, uint, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(blkdev_minors, "Number of minors(partitions)");
 
 /*
@@ -47,11 +47,11 @@ MODULE_PARM_DESC(blkdev_minors, "Number of minors(partitions)");
  * value.
  */
 static unsigned int blkdev_max_hw_sectors = 1024;
-module_param(blkdev_max_hw_sectors, uint, 0444);
+module_param(blkdev_max_hw_sectors, uint, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(blkdev_max_hw_sectors, "Max hw sectors for a single BIO");
 
 static unsigned int enable_blkdev = 1;
-module_param(enable_blkdev , uint, 0444);
+module_param(enable_blkdev , uint, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(enable_blkdev, "Enable block device interfaces");
 
 
-- 
2.9.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 0091/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 20:40 +0200

csiph-web