[PATCH -next] virtio: fix possible memory leak in virtqueue_add()

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] virtio: fix possible memory leak in virtqueue_add()
Date	2016-08-02 16:10 +0200
Message-ID	<s1Iyl-5ut-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

desc may malloced in virtqueue_add() and should be freed before
leaving from the error handling cases, otherwise it will cause
memory leak.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
 drivers/virtio/virtio_ring.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 114a0c8..bda71ef 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -328,6 +328,7 @@ static inline int virtqueue_add(struct virtqueue *_vq,
 		if (out_sgs)
 			vq->notify(&vq->vq);
 		END_USE(vq);
+		kfree(desc);
 		return -ENOSPC;
 	}

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] virtio: fix possible memory leak in virtqueue_add() Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-02 16:10 +0200
  Re: [PATCH -next] virtio: fix possible memory leak in virtqueue_add() "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-02 16:10 +0200
  [PATCH -next v2] virtio: fix possible memory leak in virtqueue_add() Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-02 16:20 +0200
    Re: [PATCH -next v2] virtio: fix possible memory leak in  virtqueue_add() "Michael S. Tsirkin" <mst@redhat.com> - 2016-08-03 06:30 +0200

csiph-web