Re: [RFC 0/4] tools lib traceevent: Install fixes

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 0/4] tools lib traceevent: Install fixes
Date	2016-08-02 16:20 +0200
Message-ID	<s1II1-5y4-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <s1ypj-786-1@gated-at.bofh.it> <s1El3-2B6-11@gated-at.bofh.it> <s1IoH-5bC-53@gated-at.bofh.it> <s1Iym-5ut-43@gated-at.bofh.it> <s1II1-5y4-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Tue, Aug 02, 2016 at 11:14:11PM +0900, Namhyung Kim escreveu:
> On Tue, Aug 02, 2016 at 04:01:44PM +0200, Jiri Olsa wrote:
> > On Tue, Aug 02, 2016 at 09:48:23AM -0400, Steven Rostedt wrote:
> > 
> > SNIP
> > 
> > > > > 
> > > > > 
> > > > > Also I think it'd be better for libtraceevent has dependency to libdl
> > > > > explicitly so that we can get rid of -ldl at the end.  
> > > > 
> > > > agreed, I'll queue your patch if v2 is needed
> > > > 
> > > 
> > > BTW, before we start making this ready for their own libraries, I'd
> > > like to make some changes with the naming convention. Mainly with
> > > event_format and format_field.
> > > 
> > > Perhaps we should change them to pevent_event and pevent_field?
> > 
> > right, it does not have any global prefix for public symbols
> > 
> > I'd actualy expect something like 'traceevent_',
> > but 'pevent' is ok as well I guess
> 
> The 'pevent' prefix would be more consistent to similar APIs IMHO.
> 
> Maybe it's worth splitting public header and internal header files?

I'd suggest exporting just what is already used by tools, exposing more
as the need arises.

- Arnaldo

Thread

[RFC 0/4] tools lib traceevent: Install fixes Jiri Olsa <jolsa@kernel.org> - 2016-08-01 19:50 +0200
  [PATCH 3/4] tools lib traceevent: Rename LIB_FILE to LIB_TARGET Jiri Olsa <jolsa@kernel.org> - 2016-08-01 19:50 +0200
  [PATCH 1/4] tools lib traceevent: Add install_headers target Jiri Olsa <jolsa@kernel.org> - 2016-08-01 19:50 +0200
    Re: [PATCH 1/4] tools lib traceevent: Add install_headers target Namhyung Kim <namhyung@kernel.org> - 2016-08-02 04:40 +0200
      Re: [PATCH 1/4] tools lib traceevent: Add install_headers target Jiri Olsa <jolsa@redhat.com> - 2016-08-02 11:40 +0200
  Re: [RFC 0/4] tools lib traceevent: Install fixes Namhyung Kim <namhyung@kernel.org> - 2016-08-02 05:20 +0200
    [PATCH 1/2] tools lib traceevent: Ignore generated library files Namhyung Kim <namhyung@kernel.org> - 2016-08-02 07:20 +0200
      [PATCH 2/2] tools lib traceevent: Add str_error_r() Namhyung Kim <namhyung@kernel.org> - 2016-08-02 07:20 +0200
        Re: [PATCH 2/2] tools lib traceevent: Add str_error_r() Namhyung Kim <namhyung@kernel.org> - 2016-08-02 17:30 +0200
      [tip:perf/urgent] tools lib traceevent: Ignore generated library  files tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-08-04 11:40 +0200
    Re: [RFC 0/4] tools lib traceevent: Install fixes Jiri Olsa <jolsa@redhat.com> - 2016-08-02 11:40 +0200
      Re: [RFC 0/4] tools lib traceevent: Install fixes Steven Rostedt <rostedt@goodmis.org> - 2016-08-02 16:00 +0200
        Re: [RFC 0/4] tools lib traceevent: Install fixes Jiri Olsa <jolsa@redhat.com> - 2016-08-02 16:10 +0200
          Re: [RFC 0/4] tools lib traceevent: Install fixes Namhyung Kim <namhyung@kernel.org> - 2016-08-02 16:20 +0200
            Re: [RFC 0/4] tools lib traceevent: Install fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-02 16:20 +0200
          Re: [RFC 0/4] tools lib traceevent: Install fixes Steven Rostedt <rostedt@goodmis.org> - 2016-08-02 16:20 +0200
          Re: [RFC 0/4] tools lib traceevent: Install fixes Steven Rostedt <rostedt@goodmis.org> - 2016-08-05 16:20 +0200
            Re: [RFC 0/4] tools lib traceevent: Install fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-05 16:50 +0200
              Re: [RFC 0/4] tools lib traceevent: Install fixes Jiri Olsa <jolsa@redhat.com> - 2016-08-07 15:00 +0200

csiph-web