Re: [PATCH v3] ARM: pxa: fix GPIO double shifts

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] ARM: pxa: fix GPIO double shifts
Date	2016-08-01 00:30 +0200
Message-ID	<s17p7-61Z-3@gated-at.bofh.it> (permalink)
References	<s0XSN-8qj-1@gated-at.bofh.it> <s15Qm-4XD-3@gated-at.bofh.it> <s175L-5Vw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-08-01 at 00:04 +0200, Robert Jarzmik wrote:
> Joe Perches <joe@perches.com> writes:
[]
> > These might be better without the automatic use of ret
> > 
> > 	return !gpio_get_value(CORGI_GPIO_AC_IN) ||
> > 	       !gpio_get_value(CORGI_GPIO_KEY_INT) ||
> > 	       !gpio_get_value(CORGI_GPIO_WAKEUP);
> Yeah, I thought about this when I made the patch.
> 
> I supposed it was written this way so that a printk was easier to add, that's
> why I didn't change the useless variable.
> 
> I have no strong opinion about this, so if you think it's worth it I can make
> the additional change.

Hi Robert.  Your choice.

It was one of those, 'oh, bother' type of things but 
I think it's worth it for readability and consistency.

cheers, Joe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] ARM: pxa: fix GPIO double shifts Robert Jarzmik <robert.jarzmik@free.fr> - 2016-07-31 14:20 +0200
  Re: [PATCH v3] ARM: pxa: fix GPIO double shifts Joe Perches <joe@perches.com> - 2016-07-31 22:50 +0200
    Re: [PATCH v3] ARM: pxa: fix GPIO double shifts Robert Jarzmik <robert.jarzmik@free.fr> - 2016-08-01 00:10 +0200
      Re: [PATCH v3] ARM: pxa: fix GPIO double shifts Joe Perches <joe@perches.com> - 2016-08-01 00:30 +0200

csiph-web