Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1452226

Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property

From Shawn Lin <shawn.lin@rock-chips.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property
Date 2016-07-29 04:50 +0200
Message-ID <s0625-6UB-5@gated-at.bofh.it> (permalink)
References <rZQgG-4ts-27@gated-at.bofh.it> <rZQgG-4ts-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


在 2016/7/28 17:55, Jaehoon Chung 写道:
> Remvoe the deprecated "supports-highspeed" property.
> DWMMC controller will not use this property anymore.
>

We had set up a flag day to remove these deprecated property
long time agao.

It doesn't *break* old dtb which may(not ?) still boot up new
kernel code as we just make it suffer from lower speed, then
I think it's time for them to migrate to the new property anyway.

So,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 1b719a6..e9faedd 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2890,11 +2890,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>  			return ERR_PTR(ret);
>  	}
>
> -	if (of_find_property(np, "supports-highspeed", NULL)) {
> -		dev_info(dev, "supports-highspeed property is deprecated.\n");
> -		pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
> -	}
> -
>  	return pdata;
>  }
>
>


-- 
Best Regards
Shawn Lin

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed"  property Jaehoon Chung <jh80.chung@samsung.com> - 2016-07-28 12:00 +0200
  Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated  "supports-highspeed" property Shawn Lin <shawn.lin@rock-chips.com> - 2016-07-29 04:50 +0200
    Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated  "supports-highspeed" property Jaehoon Chung <jh80.chung@samsung.com> - 2016-07-29 05:40 +0200

csiph-web