Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given
Date	2016-05-13 20:10 +0200
Message-ID	<rypHc-py-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <rxUtI-1Wg-9@gated-at.bofh.it> <rxYxk-6rM-21@gated-at.bofh.it> <ry5p8-4Cj-17@gated-at.bofh.it> <ryfHP-72l-3@gated-at.bofh.it> <rymgi-55V-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, May 13, 2016 at 08:27:29AM -0600, David Ahern escreveu:
> On 5/13/16 1:19 AM, Hekuang wrote:
> > > What about putting the build id cache under the symfs? so instead of
> > > dropping the symfs check and it to the path for the build id cache.

> > I think your intention is to reference symbol files in one place
> > instead of two. So there're two possible approaches, one is all
> > in buildid-cache, but in practice, I found lots of binaries in
> > symfs even not contains valid buildid, so this way is not work.

> > The other one is all in symfs. It seems ok, but one problem I
> > should point out, with my test environment as an example, the
> > symfsdir is $(TARGET_ROOTFS),and by default buildid_dir is
> > $(TARGET_ROOTFS)/$(HOME)/.debug/, host perf does not know
> > $(HOME) folder in target and we should copy the debug folder
> >  to $(TARGET_ROOTFS), which is readonly in the target. For me, it's
> > easier to use 'buildid-cache -a vdso-xxxx' to add that into host
> > buildid-cache than copy debug folder from $(HOME) to readonly
> > $(TARGET_ROOTFS).

> > Without the stale concern, I prefer the two places(buildid-dir in
> > host and target symfs) way.
> 
> The intention of symfs is every single file opened by perf is relative to
> that directory. As I recall when I added that option in early 2011 I made
> sure that statement is true. I think it is best to maintain that design.

Ok, so we can introduce --dso-prefix for Hekuang's use case, i.e. be able
to lookup by build-id, fallbacking to a (possibly read-only) directory.

This way the existing --symfs semantic remains written in stone.

- Arnaldo

Thread

Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid  cache if symfs is given Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-12 15:10 +0200
  Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid  cache if symfs is given David Ahern <dsahern@gmail.com> - 2016-05-12 22:30 +0200
    Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid  cache if symfs is given Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-12 22:40 +0200
    Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid  cache if symfs is given Hekuang <hekuang@huawei.com> - 2016-05-13 09:30 +0200
      Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid  cache if symfs is given David Ahern <dsahern@gmail.com> - 2016-05-13 16:30 +0200
        Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid  cache if symfs is given Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-13 20:10 +0200
          [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs He Kuang <hekuang@huawei.com> - 2016-05-14 10:30 +0200
            Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-14 16:50 +0200
              Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-16 04:10 +0200
                Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-16 05:00 +0200
                Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-16 08:50 +0200
                Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-18 04:00 +0200
                Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-18 04:00 +0200
                Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs Hekuang <hekuang@huawei.com> - 2016-05-18 05:00 +0200
                Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of  buildid dsos under symfs David Ahern <dsahern@gmail.com> - 2016-05-18 05:10 +0200

csiph-web