Re: [PATCH] efifb: Don't show the mapping VA

From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] efifb: Don't show the mapping VA
Date	2016-05-13 13:50 +0200
Message-ID	<ryjLs-2sD-25@gated-at.bofh.it> (permalink)
References	<rxMcO-1Os-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 12/05/16 02:57, Andy Lutomirski wrote:
> The framebuffer mapping virtual address leaks information about the
> kernel memory layout.  Stop logging it.
> 
> Cc: Peter Jones <pjones@redhat.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>  drivers/video/fbdev/efifb.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index 95d293b7445a..3dcaf4e82885 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev)
>  		goto err_release_fb;
>  	}
>  
> -	printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, "
> -	       "using %dk, total %dk\n",
> -	       efifb_fix.smem_start, info->screen_base,
> -	       size_remap/1024, size_total/1024);
> +	printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n",
> +	       efifb_fix.smem_start, size_remap/1024, size_total/1024);
>  	printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n",
>  	       efifb_defined.xres, efifb_defined.yres,
>  	       efifb_defined.bits_per_pixel, efifb_fix.line_length,
> 

Thanks, queued for 4.7.

 Tomi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] efifb: Don't show the mapping VA Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-05-13 13:50 +0200

csiph-web