Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is NULL

From	Sakari Ailus <sakari.ailus@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is NULL
Date	2016-05-13 11:40 +0200
Message-ID	<ryhJE-Hg-15@gated-at.bofh.it> (permalink)
References	<rxXKV-5Dw-1@gated-at.bofh.it> <rxXKW-5Dw-17@gated-at.bofh.it> <ryhgC-qB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Hans,

Hans Verkuil wrote:
> On 05/12/2016 02:14 PM, Sakari Ailus wrote:
>> An earlier patch fixing an input validation issue introduced another
>> issue: vb2_core_dqbuf() is called with pb argument value NULL in some
>> cases, causing a NULL pointer dereference. Fix this by skipping the
>> verification as there's nothing to verify.
>>
>> Signed-off-by: David R <david@unsolicited.net>
>>
>> Use if () instead of ? :; it's nicer that way. Improve the comment in the
>> code as well.
> 
> This comment doesn't seem applicable to this patch.

Compared to the original patch. I can sure drop the comment as well,
it's not that important.

> 
> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>

Thanks!

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] vb2: core: Skip planes array verification if pb is NULL Sakari Ailus <sakari.ailus@linux.intel.com> - 2016-05-12 14:20 +0200
  Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is  NULL Hans Verkuil <hverkuil@xs4all.nl> - 2016-05-13 11:10 +0200
    Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is  NULL Sakari Ailus <sakari.ailus@linux.intel.com> - 2016-05-13 11:40 +0200

csiph-web