Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1398644

Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation

From Jaegeuk Kim <jaegeuk@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation
Date 2016-05-11 04:40 +0200
Message-ID <rxse6-7qv-7@gated-at.bofh.it> (permalink)
References <rwS0V-4NU-5@gated-at.bofh.it> <rx2tk-76w-19@gated-at.bofh.it> <rxfqy-2xu-3@gated-at.bofh.it> <rxnHr-2F8-1@gated-at.bofh.it> <rxs4p-7l8-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, May 11, 2016 at 10:22:05AM +0800, Chao Yu wrote:
> On 2016/5/11 5:41, Jaegeuk Kim wrote:
> > +
> > +	f2fs_wait_on_page_writeback(dn->node_page, NODE, true);
> > +
> > +	for (; count > 0; dn->ofs_in_node++) {
> > +		block_t blkaddr =
> > +			datablock_addr(dn->node_page, dn->ofs_in_node);
> > +		if (blkaddr == NULL_ADDR) {
> > +			dn->data_blkaddr = NEW_ADDR;
> > +			__set_data_blkaddr(dn);
> > +			count--;
> > +		}
> > +	}
> 
> Should let ofs_in_node increase to offset where blkaddr = NULL_ADDR in
> ENOSPC case or increase to end_offset in normal case, right?

hehe, I could get some errors on this patch. :)
Finally, I've made a patch which passes xfstests and fsstress.
Could you find the latest ones?

http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev-test

> 
> Thanks,

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/6] f2fs: support in batch multi blocks preallocation Chao Yu <yuchao0@huawei.com> - 2016-05-09 14:00 +0200
  [PATCH 4/6] f2fs: make atomic/volatile operation exclusive Chao Yu <yuchao0@huawei.com> - 2016-05-09 14:00 +0200
  Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-10 01:10 +0200
    Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation Chao Yu <yuchao0@huawei.com> - 2016-05-10 15:00 +0200
      Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-10 23:50 +0200
        Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation Chao Yu <yuchao0@huawei.com> - 2016-05-11 04:30 +0200
          Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-11 04:40 +0200
            Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation Chao Yu <yuchao0@huawei.com> - 2016-05-11 05:10 +0200

csiph-web