Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1398635
| From | Chris Phlipot <cphlipot0@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/4] perf script: fix callchain addresses in db-export |
| Date | 2016-05-11 04:10 +0200 |
| Message-ID | <rxrL4-714-17@gated-at.bofh.it> (permalink) |
| References | <rxrL3-714-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Remove the call to map_ip, because it has already been called when assembling the callchain. Calling it a second time can result in incorrect addresses being used. This can have effects such as duplicate symbols being created and exported. Signed-off-by: Chris Phlipot <cphlipot0@gmail.com> --- tools/perf/util/db-export.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c index 2ef1f69..8ca4186 100644 --- a/tools/perf/util/db-export.c +++ b/tools/perf/util/db-export.c @@ -324,10 +324,7 @@ static struct call_path *call_path_from_sample(struct db_export *dbe, al.sym = node->sym; al.map = node->map; al.machine = machine; - if (al.map) - al.addr = al.map->map_ip(al.map, node->ip); - else - al.addr = node->ip; + al.addr = node->ip; db_ids_from_al(dbe, &al, &dso_db_id, &sym_db_id, &offset); -- 2.7.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 3/4] perf script: fix callchain addresses in db-export Chris Phlipot <cphlipot0@gmail.com> - 2016-05-11 04:10 +0200
csiph-web