Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399881

[tip:perf/core] perf script: Fix symbol insertion behavior in db-export

Show all headers | View raw

Commit-ID:  bd0a51dd2794f1d17d4e7a34ad66db845cef3e5a
Gitweb:     http://git.kernel.org/tip/bd0a51dd2794f1d17d4e7a34ad66db845cef3e5a
Author:     Chris Phlipot <cphlipot0@gmail.com>
AuthorDate: Tue, 10 May 2016 20:26:47 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 11 May 2016 12:24:57 -0300

perf script: Fix symbol insertion behavior in db-export

Use the dso__insert_symbol function instead of symbols__insert() in
order to properly update the dso symbol cache.

If the cache is not updated, then duplicate symbols can be
unintentionally created, inserted, and exported.

This change prevents duplicate symbols from being exported due to
dso__find_symbol() using a stale symbol cache.

Signed-off-by: Chris Phlipot <cphlipot0@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1462937209-6032-3-git-send-email-cphlipot0@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/db-export.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c
index f8e3057..2ef1f69 100644
--- a/tools/perf/util/db-export.c
+++ b/tools/perf/util/db-export.c
@@ -260,8 +260,7 @@ static int db_ids_from_al(struct db_export *dbe, struct addr_location *al,
 		if (!al->sym) {
 			al->sym = symbol__new(al->addr, 0, 0, "unknown");
 			if (al->sym)
-				symbols__insert(&dso->symbols[al->map->type],
-						al->sym);
+				dso__insert_symbol(dso, al->map->type, al->sym);
 		}
 
 		if (al->sym) {

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] perf script: fix duplicate symbols in db-export Chris Phlipot <cphlipot0@gmail.com> - 2016-05-11 05:30 +0200
  [PATCH v2 2/4] perf script: fix symbol insertion behavior in db-export Chris Phlipot <cphlipot0@gmail.com> - 2016-05-11 05:30 +0200
    [tip:perf/core] perf script: Fix symbol insertion behavior in  db-export tip-bot for Chris Phlipot <tipbot@zytor.com> - 2016-05-12 12:30 +0200
  [PATCH v2 4/4] perf script: fix export of callchains with recursion in db-export Chris Phlipot <cphlipot0@gmail.com> - 2016-05-11 05:30 +0200
    [tip:perf/core] perf script: Fix export of callchains with  recursion in db-export tip-bot for Chris Phlipot <tipbot@zytor.com> - 2016-05-12 12:30 +0200
  [PATCH v2 3/4] perf script: fix callchain addresses in db-export Chris Phlipot <cphlipot0@gmail.com> - 2016-05-11 05:30 +0200
    [tip:perf/core] perf script: Fix callchain addresses in db-export tip-bot for Chris Phlipot <tipbot@zytor.com> - 2016-05-12 12:30 +0200
  [PATCH v2 1/4] perf symbols: add dso__insert_symbol function Chris Phlipot <cphlipot0@gmail.com> - 2016-05-11 05:30 +0200
    [tip:perf/core] perf symbols: Add dso__insert_symbol function tip-bot for Chris Phlipot <tipbot@zytor.com> - 2016-05-12 12:30 +0200

csiph-web