Re: [PATCH v8 6/8] dt-bindings: i2c: rk3x: add support for rk3399

From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 6/8] dt-bindings: i2c: rk3x: add support for rk3399
Date	2016-05-11 20:30 +0200
Message-ID	<rxH3s-5o7-21@gated-at.bofh.it> (permalink)
References	<rxtDc-wb-3@gated-at.bofh.it> <rxtDc-wb-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Mittwoch, 11. Mai 2016, 03:30:47 schrieb David Wu:
> The bus clock and function clock are separated at rk3399,
> and others use one clock as the bus clock and function clock.
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

I'd second what Doug said wrt. the removal of the unnecessary "REQUIRED" 
statements of the clock names, especially as the surrounding text makes that 
requirement pretty clear.

Otherwiese looks nice, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
> Change in v8:
> - remove error description.
> 
>  Documentation/devicetree/bindings/i2c/i2c-rk3x.txt | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
> b/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt index
> 0b4a85f..5429301 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
> @@ -6,10 +6,20 @@ RK3xxx SoCs.
>  Required properties :
> 
>   - reg : Offset and length of the register set for the device
> - - compatible : should be "rockchip,rk3066-i2c", "rockchip,rk3188-i2c",
> -		"rockchip,rk3228-i2c" or "rockchip,rk3288-i2c".
> + - compatible: should be one of the following:
> +   - "rockchip,rk3066-i2c": for rk3066
> +   - "rockchip,rk3188-i2c": for rk3188
> +   - "rockchip,rk3228-i2c": for rk3228
> +   - "rockchip,rk3288-i2c": for rk3288
> +   - "rockchip,rk3399-i2c": for rk3399
>   - interrupts : interrupt number
> - - clocks : parent clock
> + - clocks: See ../clock/clock-bindings.txt
> +   - For older hardware (rk3066, rk3188, rk3228, rk3288):
> +     - There is one clock that's used both to derive the functional clock
> +       for the device and as the bus clock.
> +   - For newer hardware (rk3399): specified by name
> +     - "i2c": REQUIRED. This is used to derive the functional clock.
> +     - "pclk": REQUIRED. This is the bus clock.
> 
>  Required on RK3066, RK3188 :

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v8 6/8] dt-bindings: i2c: rk3x: add support for rk3399 David Wu <david.wu@rock-chips.com> - 2016-05-11 06:10 +0200
  Re: [PATCH v8 6/8] dt-bindings: i2c: rk3x: add support for rk3399 Doug Anderson <dianders@chromium.org> - 2016-05-11 18:40 +0200
    Re: [PATCH v8 6/8] dt-bindings: i2c: rk3x: add support for rk3399 "David.Wu" <david.wu@rock-chips.com> - 2016-05-12 03:20 +0200
  Re: [PATCH v8 6/8] dt-bindings: i2c: rk3x: add support for rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-05-11 20:30 +0200

csiph-web