Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled

From	Jeff Moyer <jmoyer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled
Date	2016-05-11 15:50 +0200
Message-ID	<rxCGu-Pf-7@gated-at.bofh.it> (permalink)
References	<rx3IK-8cV-13@gated-at.bofh.it> <rx3IK-8cV-11@gated-at.bofh.it> <rxieL-5nU-25@gated-at.bofh.it> <rxqch-5lh-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Shaohua Li <shli@fb.com> writes:

> On Tue, May 10, 2016 at 11:52:15AM -0400, Jeff Moyer wrote:
>> Shaohua Li <shli@fb.com> writes:
>> 
>> > if trace isn't enabled, parsing cgroup path just wastes cpu
>> >
>> > Signed-off-by: Shaohua Li <shli@fb.com>
>> > ---
>> >  block/blk-throttle.c         | 5 ++---
>> >  include/linux/blktrace_api.h | 9 +++++++++
>> >  2 files changed, 11 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/block/blk-throttle.c b/block/blk-throttle.c
>> > index 2149a1d..47a3e54 100644
>> > --- a/block/blk-throttle.c
>> > +++ b/block/blk-throttle.c
>> > @@ -211,15 +211,14 @@ static struct throtl_data *sq_to_td(struct throtl_service_queue *sq)
>> >   *
>> >   * The messages are prefixed with "throtl BLKG_NAME" if @sq belongs to a
>> >   * throtl_grp; otherwise, just "throtl".
>> > - *
>> > - * TODO: this should be made a function and name formatting should happen
>> > - * after testing whether blktrace is enabled.
>> 
>> You've only addressed the second part of the TODO, please don't remove
>> the first part.
>
> alright, I'll send a patch to convert it to a function.

Heh.  I figured you'd just put that part of the TODO back in there.  But
actually addressing it sounds better.  ;-)

Thanks!
Jeff

Thread

[PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled Shaohua Li <shli@fb.com> - 2016-05-10 02:30 +0200
  Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled Jeff Moyer <jmoyer@redhat.com> - 2016-05-10 18:00 +0200
    Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace  isn't enabled Steven Rostedt <rostedt@goodmis.org> - 2016-05-11 01:40 +0200
      Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled Jeff Moyer <jmoyer@redhat.com> - 2016-05-11 15:50 +0200
    Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't  enabled Shaohua Li <shli@fb.com> - 2016-05-11 02:30 +0200
      Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled Jeff Moyer <jmoyer@redhat.com> - 2016-05-11 15:50 +0200
        Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't  enabled Shaohua Li <shli@fb.com> - 2016-05-11 19:00 +0200
  Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't  enabled Simon Guo <wei.guo.simon@gmail.com> - 2016-05-11 10:20 +0200
    Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't  enabled Shaohua Li <shli@fb.com> - 2016-05-11 19:00 +0200

csiph-web