Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks
Date	2016-05-10 01:10 +0200
Message-ID	<rx2tk-76w-17@gated-at.bofh.it> (permalink)
References	(2 earlier) <rwCpb-4eI-9@gated-at.bofh.it> <rwY6l-2x2-3@gated-at.bofh.it> <rwY6l-2x2-1@gated-at.bofh.it> <rx0KT-5bF-11@gated-at.bofh.it> <rx29X-6uv-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-05-09 at 16:34 -0600, Toshi Kani wrote:
> On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote:
 :
> > > > > 
> > > > > This patch should replace blkdev_dax_capable(), or just reuse
> > > > > that existing routine, or am I missing something?
> > > >
> > > > Good question.  bdev_supports_dax() is a helper function tailored
> > > > for the filesystem's mount -o dax case.  While blkdev_dax_capable()
> > > > is similar, it does not need error messages like "device does not
> > > > support dax" since it implicitly enables dax when capable.  So, I
> > > > think we can keep blkdev_dax_capable(), but change it to call
> > > > bdev_direct_access() so that actual check is performed in a single
> > > > place.
> > >
> > > Sounds good to me.
> >
> > Can you name them consistently then? i.e. blkdev_dax_supported() and
> > blkdev_dax_capable()?
>
> Sure.  Will do.

I will keep the "bdev_" prefix to be consistent with bdev_direct_access(),
i.e. bdev_dax_supported() and bdev_dax_capable().

-Toshi

Thread

[PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks Toshi Kani <toshi.kani@hpe.com> - 2016-05-06 02:40 +0200
  Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount  checks Christoph Hellwig <hch@infradead.org> - 2016-05-08 11:00 +0200
  Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks Dan Williams <dan.j.williams@intel.com> - 2016-05-08 21:20 +0200
    Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks Dan Williams <dan.j.williams@intel.com> - 2016-05-09 20:30 +0200
      Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount  checks Dave Chinner <david@fromorbit.com> - 2016-05-09 23:20 +0200
        Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount  checks Toshi Kani <toshi.kani@hpe.com> - 2016-05-10 00:50 +0200
          Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount  checks Toshi Kani <toshi.kani@hpe.com> - 2016-05-10 01:10 +0200
    Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount  checks Toshi Kani <toshi.kani@hpe.com> - 2016-05-09 20:30 +0200

csiph-web