Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395064

Re: [PATCH 3/3] net-next: mediatek: add RX delay support

Show all headers | View raw

On Thu, May 05, 2016 at 11:17:36AM +0200, John Crispin wrote:
> If an external Gigabit PHY is connected to either of the MACs we need to
> tell the to use a RX delay. Not doing so will result in heavy packet loss
> and/or data corruption of RX traffic.

Hi John

Is this comment correct? Reading the code, all this switch statement
does is select between RGMII, MII and RMII. It has nothing to do with
delay. I suspect the PHY is doing the delay, not the MAC, since you
pass the phy mode to of_phy_connect().

If my interpretation of the code is correct, you might also want to
handle PHY_INTERFACE_MODE_RGMII_TXID and PHY_INTERFACE_MODE_RGMII_ID
which are also RGMII modes.

      Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] net-next: mediatek: add RX delay support John Crispin <john@phrozen.org> - 2016-05-05 11:30 +0200
  Re: [PATCH 3/3] net-next: mediatek: add RX delay support Andrew Lunn <andrew@lunn.ch> - 2016-05-05 14:20 +0200
    Re: [PATCH 3/3] net-next: mediatek: add RX delay support John Crispin <john@phrozen.org> - 2016-05-05 19:40 +0200

csiph-web