Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface
Date	2016-05-06 13:40 +0200
Message-ID	<rvMgW-466-3@gated-at.bofh.it> (permalink)
References	<rvM7f-3YW-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 6, 2016 at 2:20 PM, Maarten Brock <m.brock@vanmierlo.com> wrote:
>> > >
>> > > +       bool                    polarity;
>> > So this variable is not very intuitively named.
>>
>> There is a help above. This is a property of the Synopsys DesignWare DMA
>> engine. Anyone familiar with datasheet easily understands this.
>>
>> >
>> > You end up setting somepointer->polarity = true; in a later patch.
>> >
>> > Since you're respining a V4 I'd suggest a name that describes a little
>> > bit better than polarity. Setting polarity = true is a little bit
>> > liked being asked "you you like ice-cream or apple pie" and then
>> > saying "yes please".
>>
>> It's about handshake interface polarity, so, what about hs_polarity?
>
> So it means: handshake has polarity (true) or handshake has no polarity
> (omnidirectional?) (false), right?

It means that handshake polarity _signal_ is inverted (true) or
default (false) in terms of hardware gates.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake  interface "Maarten Brock" <m.brock@vanmierlo.com> - 2016-05-06 13:30 +0200
  Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-06 13:40 +0200

csiph-web